docs: обновить раздел Linux-зависимостей в README#1671
Open
johnnyshut wants to merge 2 commits intoEvilBeaver:developfrom
Open
docs: обновить раздел Linux-зависимостей в README#1671johnnyshut wants to merge 2 commits intoEvilBeaver:developfrom
johnnyshut wants to merge 2 commits intoEvilBeaver:developfrom
Conversation
…md с добавлением информации о вариантах ZIP-архивов для .NET 8.0 и необходимых зависимостях
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughDocumentation updates adding Linux installation instructions for v2.x (.NET 8.0: SCD vs FDD) and v1.x LTS (Mono .deb), clarifying runtime and debugging (mono-complete) requirements and adjusting chmod example. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
README-EN.md (1)
50-52: ⚡ Quick winMinor doc clarity: make the chmod command explicitly relative.
For the extracted ZIP, consider updating (Line 51) to
chmod +x ./oscriptso it’s unambiguous that it targets the binary in the current directory.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README-EN.md` around lines 50 - 52, Update the README-EN.md instruction that currently shows the chmod example to explicitly reference the local binary by changing the existing `chmod +x oscript` line to `chmod +x ./oscript`; locate the code block containing the `oscript` chmod example and replace the command so it unambiguously targets the binary in the current directory.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README-EN.md`:
- Line 56: The ATX heading "#### v1.x LTS — deb package (Mono)" violates MD003;
update this heading to use the closed ATX style by adding trailing hashes so it
becomes "#### v1.x LTS — deb package (Mono) ####" (i.e., modify the heading
string in the README to include closing '#' characters for the same level).
- Line 37: The heading "#### v2.x (current branch) — .NET 8.0 based" should use
closed ATX style to match the repo and silence MD003; update that heading to
include trailing hashes (e.g., "#### v2.x (current branch) — .NET 8.0 based
####") so it is consistent with other headings like "### Windows ###".
In `@README.md`:
- Line 56: Update the Russian heading "#### v1.x LTS — deb-пакет (Mono)" to
closed ATX style by appending trailing hashes so it becomes "#### v1.x LTS —
deb-пакет (Mono) ####", ensuring consistency with other headings and satisfying
markdownlint MD003; modify the heading text exactly where "v1.x LTS — deb-пакет
(Mono)" appears.
- Line 37: The heading "#### v2.x (текущая ветка) — на базе .NET 8.0" is using
an open ATX style while other headings use closed ATX; update that heading (the
string "v2.x (текущая ветка) — на базе .NET 8.0") to a closed style by appending
trailing hashes (e.g., "#### v2.x (текущая ветка) — на базе .NET 8.0 ####") so
it matches the rest of the README's heading style.
---
Nitpick comments:
In `@README-EN.md`:
- Around line 50-52: Update the README-EN.md instruction that currently shows
the chmod example to explicitly reference the local binary by changing the
existing `chmod +x oscript` line to `chmod +x ./oscript`; locate the code block
containing the `oscript` chmod example and replace the command so it
unambiguously targets the binary in the current directory.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
… .NET 8.0 и LTS версии, добавление символов завершения
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Зачем
Закрыть #1437: актуализировать документацию по установке зависимостей для Linux без изменений в коде ядра.
Что изменили
README.mdиREADME-EN.md.v2.x(на базе .NET 8): уточнили различие SCD/FDD и требование runtime для FDD.v1.x LTS: уточнили зависимость от Mono для сценариев отладки.Что НЕ меняли
Summary by CodeRabbit