Fix a bunch of issues on desktop#343
Merged
Merged
Conversation
Previously it didn't account for the PD differences. It only has a
single PD at a different address.
$ sudo framework_tool --test
Self-Test
SMBIOS Platform: FrameworkDesktopAmdAiMax300
Dump EC memory region
00000000: 7877 7679 77ff ffff ffff ffff ffff ffff xwvyw...........
00000010: 0000 0000 0000 ffff ffff ffff ffff ffff ................
00000020: 4543 0102 0001 0103 0000 0000 0000 0000 EC..............
00000030: 0500 0000 0000 0000 0000 0000 0000 0000 ................
00000040: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000050: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000060: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000070: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000080: 0000 0000 0000 0000 0000 0000 0000 0000 ................
00000090: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000a0: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000b0: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000c0: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000d0: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000e0: 0000 0000 0000 0000 0000 0000 0000 0000 ................
000000f0: 0000 0000 0000 0000 0000 0000 0000 ..............
Checking EC memory mapped magic bytes
Verified that Framework EC is present!
Reading EC Build Version
Reading EC Flash by EC - OK
Reading EC Flash directly - See below
Read first row of flash (RO FW)
[5E, 4D, 3B, 2A, E1, 54, 0C, 03]
Read first row of RW FW
[00, 58, 0C, 20, 45, 22, 09, 10]
Read flash flags
Valid flash flags
Getting power info from EC - OK
Getting AC info from EC
Reading PD Version from EC - OK
Getting Back PD info through I2C tunnel - OK
Signed-off-by: Daniel Schaefer <dhs@frame.work>
It's a virtual thermal sensor. See: https://github.com/FrameworkComputer/EmbeddedController/blob/fwk-dogwood-27111/zephyr/program/framework/dogwood/thermal.dtsi Signed-off-by: Daniel Schaefer <dhs@frame.work>
Desktop only has two PD ports, gracefully handle the EC telling us the requested index does not exist. This way we don't have to encode the PD number into the code here, we can just let the EC tell us how many there are. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Useful for systems with more than one fan (Laptop 16, Desktop) Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
test-desktop
branch
from
75fa2eb to
f18ab2d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commit messages
Fixes: #253