docs: document secret mount path caveat#763
Open
Haihan-Jiang wants to merge 1 commit into
Open
Conversation
Haihan-Jiang
changed the title
Haihan-Jiang
force-pushed
the
docs-secret-workspace-mount
branch
from
ca8be13 to
86e0300
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a short deployment note about
gcloud functions deploy --set-secrets: do not mount a secret over/workspace, because Cloud Run functions load the deployed source from that directory. The note points users at safer file mount locations such as/etc/secretsor/tmp.Fixes #696.
Testing
git diff --check -- README.mdnpm cinpm run check(passes with the existingsrc/function_registry.tsunused-vars warning)npm run compilenpx mocha 'build/test/**/*.js' --exclude 'build/test/system-test/**'(105 passing)I also tried the full
npm test; the non-system tests passed, but the pack-n-play system test failed while npm was resolvingundici-types@>=7.24.0 <7.24.7for a temporary package install.