fix(deps): update dependency @google-cloud/firestore to v6 [security]#657
Conversation
|
/gcbrun |
There was a problem hiding this comment.
Code Review
This pull request updates the @google-cloud/firestore dependency from version 5.0.0 to 6.2.0 across several modules. Feedback indicates that for the sessions module, the @google-cloud/connect-firestore package must also be upgraded to version 3.0.0 to ensure compatibility with the new Firestore version and avoid potential runtime issues.
| "@google-cloud/connect-firestore": "^2.0.0", | ||
| "@google-cloud/firestore": "^5.0.0", | ||
| "@google-cloud/firestore": "^6.2.0", |
There was a problem hiding this comment.
Upgrading @google-cloud/firestore to v6 (a major version bump) requires a corresponding update to @google-cloud/connect-firestore to version ^3.0.0. The current version (^2.0.0) is incompatible with Firestore v6, which will lead to peer dependency conflicts and potential runtime errors during session management.
Note: Upgrading to connect-firestore v3 also requires a code change in sessions/index.js: the dataset property in the FirestoreStore constructor should be renamed to firestore to align with the updated API.
| "@google-cloud/connect-firestore": "^2.0.0", | |
| "@google-cloud/firestore": "^5.0.0", | |
| "@google-cloud/firestore": "^6.2.0", | |
| "@google-cloud/connect-firestore": "^3.0.0", | |
| "@google-cloud/firestore": "^6.2.0", |
b7a9dcf to
eb34221
Compare
|
/gcbrun |
eb34221 to
f54dd63
Compare
|
/gcbrun |
f54dd63 to
11128d7
Compare
|
/gcbrun |
11128d7 to
1e960fd
Compare
|
/gcbrun |
1e960fd to
f2a0403
Compare
|
/gcbrun |
f2a0403 to
dbfafb9
Compare
|
/gcbrun |
This PR contains the following updates:
^5.0.0→^6.2.0GitHub Vulnerability Alerts
CVE-2023-6460
A potential logging of the firestore key via logging within nodejs-firestore exists - Developers who were logging objects through this._settings would be logging the firestore key as well potentially exposing it to anyone with logs read access. We recommend upgrading to version 6.1.0 to avoid this issue
Severity
CVSS:3.1/AV:L/AC:H/PR:H/UI:R/S:U/C:H/I:N/A:NRelease Notes
googleapis/google-cloud-node (@google-cloud/firestore)
v6.2.0Compare Source
Features
Bug Fixes
v6.0.0Compare Source
⚠ BREAKING CHANGES
Features
Bug Fixes
Build System
5.0.2 (2022-01-07)
Bug Fixes
5.0.1 (2021-12-02)
Bug Fixes
v5.0.2Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.