Skip to content

New node: 'String Capitalization'#4043

Merged
Keavon merged 2 commits intomasterfrom
string-capitalization-node
Apr 24, 2026
Merged

New node: 'String Capitalization'#4043
Keavon merged 2 commits intomasterfrom
string-capitalization-node

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Apr 24, 2026

  • String Capitalization: Converts a string's capitalization style (lower case, UPPER CASE, Capital Case, Headline Case, Sentence case, camelCase) with an optional word separator.

Broken out from #4010.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 8 files

Confidence score: 5/5

  • This PR looks low risk to merge: the only reported issue is a low-severity documentation mismatch (2/10) rather than a functional defect.
  • In node-graph/nodes/text/src/lib.rs, a comment appears to describe the opposite of if use_joiner, which can mislead future maintenance but should not change runtime behavior by itself.
  • Pay close attention to node-graph/nodes/text/src/lib.rs - update the contradictory comment so the control flow intent is clear.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/text/src/lib.rs">

<violation number="1" location="node-graph/nodes/text/src/lib.rs:160">
P3: This comment contradicts the condition (`if use_joiner`) and describes the opposite behavior, which makes the control flow misleading.

(Based on your team's feedback about aligning behavior with comments and TODO expectations.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread node-graph/nodes/text/src/lib.rs Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new String Capitalization node, enabling various casing styles such as Headline, Sentence, and Camel case, with optional word joining using custom separators. Additionally, the string_slice and string_length nodes have been updated to use grapheme clusters for improved accuracy, and slice indices were transitioned from floating-point numbers to integers. Review feedback highlighted a compilation error in the string_slice logic caused by type mismatches and recommended normalizing character casing in the manual CapitalCase implementation to ensure consistency across different modes.

Comment thread node-graph/nodes/text/src/lib.rs
Comment thread node-graph/nodes/text/src/lib.rs
@Keavon Keavon merged commit 328c4f2 into master Apr 24, 2026
11 checks passed
@Keavon Keavon deleted the string-capitalization-node branch April 24, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant