Added an extraction of the language setting from cookies#1097
Open
sergei-bondarenko wants to merge 4 commits intoHelloZeroNet:masterfrom
Open
Added an extraction of the language setting from cookies#1097sergei-bondarenko wants to merge 4 commits intoHelloZeroNet:masterfrom
sergei-bondarenko wants to merge 4 commits intoHelloZeroNet:masterfrom
Conversation
Owner
|
The problem is the Translate object is shared between users, so if you change it to someone, then it will change to everyone who currently connected via websocket. |
Contributor
Author
|
@HelloZeroNet So the translation must be comletely moved to the frontend -- rewritten in javascript. Do you think it will be the clearest solution too? |
Owner
|
i'm not sure how would parametized translations (eg.: |
Contributor
Author
|
@HelloZeroNet What if the websocket will send messages in English and then we translate it via simple substitution in JS that will not touch parametrized output at all. Something like this: What do you think? |
helzy4077
approved these changes
Oct 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#688
If the user doesn't have language setting in his cookies then value from the zeronet.conf will be used.