Make sure data types are correct / expected#896
Open
MuxZeroNet wants to merge 1 commit intoHelloZeroNet:masterfrom
Open
Make sure data types are correct / expected#896MuxZeroNet wants to merge 1 commit intoHelloZeroNet:masterfrom
MuxZeroNet wants to merge 1 commit intoHelloZeroNet:masterfrom
Conversation
Distinguish between detected errors and unexpected errors.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a partial fix of various type assumption glitches in ZeroNet.
These corrections are made as response to a very simple fuzz testing I conducted against FileServer. (I will write about the fuzz testing soon.) That 15441 port is open to everyone in the network, so it's better to be conservative.
I also make it distinguish between detected errors and unexpected errors. By making a distinction between detected errors and unexpected errors, logging noise is reduced, and more important error logs can be seen easier.