Stabilize PowerShell v7.6.1 build#39
Open
adilhusain-s wants to merge 1 commit into
Open
Conversation
The PowerShell v7.5.1 build was failing in CI because NuGet CVEs were being detected, and the build path also hit GitHub-only rate limiting when release metadata was fetched anonymously. Refresh the PowerShell patch and tar inputs to v7.6.1 and make the .NET installer consume the GitHub token passed through the reusable workflow so the metadata fetch path is authenticated in CI. Signed-off-by: Adilhusain Shaikh <Adilhusain.Shaikh@ibm.com>
adilhusain-s
requested review from
anup-kodlekere,
mtarsel and
rahulssv-ibm
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The PowerShell
v7.5.1build was failing in CI. The immediate failure was inthe
.NETrestore/build step: some NuGet packages used by that PowerShellrelease had become obsolete and were flagged with CVEs, so
dotnetrefused tocontinue the build.
There was a second issue in the same path as well. The GitHub metadata lookup
in
PowerShell/dotnet-install.pycould hit rate limits when it ran without anauthenticated token.
What changed
v7.6.1forppc64leands390x.MakefileandPowerShell/Dockerfileso the PowerShell build can receive the GitHub token as a Docker BuildKit secret.PowerShell/dotnet-install.pyto readGITHUB_TOKENorGITHUB_TOKEN_FILEand send authenticated GitHub API requests.tests/test_dotnet_install.py.Why this shape
These changes stay together because they fix the same broken build path: move
off the
v7.5.1inputs that no longer build cleanly, and make the replacementpath more reliable in CI by authenticating the metadata fetch.
Validation
actionlint.ppc64leVM and verifiedpwsh --versionfrom the resulting image.