NPE for preview of draft file with retention period#12434
Open
jo-pol wants to merge 1 commit into
Open
Conversation
qqmyers
reviewed
Jun 4, 2026
| #{bundle['file.metadataTab.fileMetadata.publicationDate.label']} | ||
| </th> | ||
| <td>#{(empty FilePage.file.embargo) and !(empty FilePage.file.released) and !(empty FilePage.file.retention) ? ''.concat(FilePage.file.publicationDateFormattedYYYYMMDD).concat('; ') : ''} | ||
| <td>#{(empty FilePage.file.embargo) and FilePage.file.released and !(empty FilePage.file.retention) ? FilePage.file.publicationDateFormattedYYYYMMDD : ''} |
Member
There was a problem hiding this comment.
I think the root cause is not addressed by this fix, although I can see why it would work. Since FilePage.file.released is a boolean !(empty FilePage.file.released) is always true (false is not empty). So the first branch with the concats runs when the publication date is null. I think if you replace that with FilePage.file.released it should work without needing to split adding the ; into a separate step. (Unless we have a bug where the released is true and the pub date is still null. If so, testing if the pub date is null might be a better choice.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR closes:
Special notes for your reviewer:
The change was suggested by copilot, it fixes the reported problem but I'm pretty clueless.
Suggestions on how to test this:
See issue
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: