Refactor dpnp includes and add extension example#2941
Draft
ndgrigorian wants to merge 9 commits into
Draft
Conversation
Enables find_package(Dpnp) out of the box
move dpnp4pybind11.hpp and usm_ndarray_constants.h into a top-level include directory, similar to original dpctl layout
makes include explicit
serves to test dpnp cmake integration
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/2941/index.html |
Collaborator
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev0=py313h509198e_74 ran successfully. |
622aa32 to
c735f53
Compare
cae3b56 to
020e5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes a refactor of dpnp's includes and the introduction of an example extension, to be tested to make sure examples using dpnp and dpnp.tensor can be written.
The
usm_ndarray_constants.hheader anddpnp4pybind11.hppare moved todpnp/include, removing a relative include and aligning with previous dpctl behavior.Also introduces dpnp-config.cmake, which enables
find_package(Dpnp)out of the box, which is installed with dpnp, and--cmakedircommand line option, which leads to the CMake config.