Remove dpnp.row_stack in favor of dpnp.vstack#2957
Merged
Conversation
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
Collaborator
|
coverage: 78.088% (-0.004%) from 78.092% — remove-np.row_stack into master |
vlad-perevezentsev
approved these changes
Jun 18, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thank you @antonwolfy
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev1=py313h509198e_17 ran successfully. |
github-actions Bot
added a commit
that referenced
this pull request
Jun 18, 2026
`numpy.row_stack` was an alias of `numpy.vstack`, deprecated since NumPy 2.0 and removed in NumPy 2.5. This PR mirrors that removal: `dpnp.row_stack` is removed in favor of`dpnp.vstack`. Accessing `dpnp.row_stack` now raises `AttributeError`; use`dpnp.vstack` instead. 7cbdf70
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
numpy.row_stackwas an alias ofnumpy.vstack, deprecated since NumPy 2.0 and removed in NumPy 2.5.This PR mirrors that removal:
dpnp.row_stackis removed in favor ofdpnp.vstack. Accessingdpnp.row_stacknow raisesAttributeError; usedpnp.vstackinstead.