Replace mkl-service dependency with mkl#188
Merged
ndgrigorian merged 2 commits intomainfrom Apr 10, 2026
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
antonwolfy
previously approved these changes
Apr 10, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
And also it'd be good to populate the chanagelog
Collaborator
Author
|
@antonwolfy |
antonwolfy
approved these changes
Apr 10, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
No more comments from me.
Thank you @ndgrigorian
antonwolfy
approved these changes
Apr 10, 2026
Collaborator
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
Thank you @ndgrigorian
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkl-servicewas used to getmkldependency inmkl_umath, butmkl-servicefunctionality is never used in the packageFor the sake of preventing unnecessary dependencies,
mkl-serviceis dropped as a dependency in favor ofmkl. Users can separately installmkl-serviceif they require runtime control ofmkl.