Move remaining path functions from Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node#6586
Open
palas wants to merge 5 commits into
Open
Move remaining path functions from Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node#6586palas wants to merge 5 commits into
Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node#6586palas wants to merge 5 commits into
Conversation
palas
changed the title
Defaults module in cardano-testnet to Cardano.Node.Testnet.Paths in cardano-node
palas
force-pushed
the
move-more-defaults-to-node
branch
from
4397ada to
ceb1f79
Compare
palas
force-pushed
the
move-more-defaults-to-node
branch
from
ceb1f79 to
3ed9ac6
Compare
carbolymer
reviewed
Jun 2, 2026
| @@ -4,66 +4,255 @@ | |||
| -- testnet configurations depend on this module so that directory | |||
| -- layout changes are kept in sync at compile time. | |||
| module Cardano.Node.Testnet.Paths | |||
Contributor
There was a problem hiding this comment.
Suggestion: use singular nouns for modules
Suggested change
| module Cardano.Node.Testnet.Paths | |
| module Cardano.Node.Testnet.Path |
carbolymer
reviewed
Jun 2, 2026
|
|
||
| import Test.Cardano.Ledger.Core.Rational | ||
| import Cardano.Node.Testnet.Paths (defaultNodeName, defaultNodeDataDir, defaultUtxoSKeyPath, | ||
| import Cardano.Node.Testnet.Paths (defaultCommitteeKeysDir, defaultCommitteeName, |
Contributor
There was a problem hiding this comment.
I guess explicit imports don't make sense for this one? The functions are quite distinguishable imo.
carbolymer
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #6532.
Move all path and filename definition functions from
Testnet.Defaults(incardano-testnet) toCardano.Node.Testnet.Paths(incardano-node), so that consumers of generated testnetconfigurations can reference canonical paths without depending on
cardano-testnet.Checklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12