Skip to content

Fix and test reuse_symbolic=false for UMFPACK lu!()#712

Merged
araujoms merged 2 commits intoJuliaSparse:mainfrom
johnomotani:fix-umfpack-reuse_symbolic-is-false
May 7, 2026
Merged

Fix and test reuse_symbolic=false for UMFPACK lu!()#712
araujoms merged 2 commits intoJuliaSparse:mainfrom
johnomotani:fix-umfpack-reuse_symbolic-is-false

Conversation

@johnomotani
Copy link
Copy Markdown
Contributor

The reuse_symbolic=false option for UMFPACK's lu!() is broken, due to undefined Tv and Ti. This PR fixes that bug, and adds a test that uses reuse_symbolic=false.

@johnomotani johnomotani force-pushed the fix-umfpack-reuse_symbolic-is-false branch from ca58792 to 126e589 Compare May 6, 2026 14:27
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.40%. Comparing base (6de7bed) to head (5181f06).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #712      +/-   ##
==========================================
- Coverage   84.42%   84.40%   -0.03%     
==========================================
  Files          13       13              
  Lines        9400     9400              
==========================================
- Hits         7936     7934       -2     
- Misses       1464     1466       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@araujoms
Copy link
Copy Markdown
Contributor

araujoms commented May 7, 2026

Instead of copy-pasting the entire test you could add another loop for reuse in (true, false).

@johnomotani
Copy link
Copy Markdown
Contributor Author

Instead of copy-pasting the entire test you could add another loop for reuse in (true, false).

@araujoms - done.

Copy link
Copy Markdown
Contributor

@araujoms araujoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@araujoms araujoms merged commit 40d5de2 into JuliaSparse:main May 7, 2026
9 of 10 checks passed
@johnomotani johnomotani deleted the fix-umfpack-reuse_symbolic-is-false branch May 7, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants