pgcopy,pgwire: fix CSV decoding of quoted NULL markers and end-of-copy marker#36732
Open
def- wants to merge 1 commit into
Open
pgcopy,pgwire: fix CSV decoding of quoted NULL markers and end-of-copy marker#36732def- wants to merge 1 commit into
def- wants to merge 1 commit into
Conversation
…y marker The csv crate strips quoting during parsing, so `decode_copy_format_csv` could not distinguish a quoted NULL marker from an unquoted one (silent data corruption: e.g. with default params, a literal `""` decoded to SQL NULL instead of the empty string), and the end-of-copy marker check treated a quoted `"\."` value as the bare `\.` terminator (silent data loss: the row and every subsequent row were dropped). Switch the decoder to csv-core so we can inspect each field's leading input byte and recover per-field quote state; the NULL-marker and end-of-copy checks both now require the field to be unquoted. The pgwire COPY row scanner had the same quote-blind end-marker check; switch it to match against the raw input bytes for the in-progress record. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The csv crate strips quoting during parsing, so
decode_copy_format_csvcould not distinguish a quoted NULL marker from an unquoted one (silent data corruption: e.g. with default params, a literal""decoded to SQL NULL instead of the empty string), and the end-of-copy marker check treated a quoted"\."value as the bare\.terminator (silent data loss: the row and every subsequent row were dropped).Switch the decoder to csv-core so we can inspect each field's leading input byte and recover per-field quote state; the NULL-marker and end-of-copy checks both now require the field to be unquoted. The pgwire COPY row scanner had the same quote-blind end-marker check; switch it to match against the raw input bytes for the in-progress record.