Continuing unit test shift I : Migrating the unmanageble to the unimaginable.#229
Draft
R Sharp (r-sharp) wants to merge 31 commits intoMetOffice:mainfrom
Draft
Continuing unit test shift I : Migrating the unmanageble to the unimaginable.#229R Sharp (r-sharp) wants to merge 31 commits intoMetOffice:mainfrom
R Sharp (r-sharp) wants to merge 31 commits intoMetOffice:mainfrom
Conversation
…iple lines, plus accidentally running ruff.
… changing it so that lines which previously passed now fail, they're going to get a jolly hard stare....
Mostly typos and tidying. All changes suggested by reviewers and very sensible they were too. Co-authored-by: James Bruten <109733895+james-bruten-mo@users.noreply.github.com> Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
The way the actual tests were originally set up in UMDP3 checker was "a tad overkill".
They're methods of a class that's no longer used for anything except the the getters to provide the dispatch tables.
The effect can be just as easily achieved by having lists of the functons imported elsewhere.
As the new approach lacks the layer of complexity provided by a whole class, it makes unit testing easier.
As the tests are migrated into the new files, the unit tests for them are also altered to use the "example" code (with modifications to provoke erros)
Code Quality Checklist
Testing
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review