[7.0] Display a warning if Renamer is not present using legacy Forge versions#1071
Open
Jonathing wants to merge 2 commits intoMinecraftForge:FG_7.0from
Open
[7.0] Display a warning if Renamer is not present using legacy Forge versions#1071Jonathing wants to merge 2 commits intoMinecraftForge:FG_7.0from
Jonathing wants to merge 2 commits intoMinecraftForge:FG_7.0from
Conversation
PaintNinja
requested changes
Apr 6, 2026
Comment on lines
+117
to
+118
| void reportMissingRenamerCheckFailed(Dependency dependency, Throwable e) { | ||
| LOGG |
Member
Author
There was a problem hiding this comment.
no way, i forgot to finish that method. awesome.
| Dependency: '%s'""" | ||
| .formatted(Util.toString(dependency))) | ||
| .severity(Severity.WARNING) | ||
| .solution("Apply the 'net.minecraftforge.renamer' plugin.") |
Contributor
There was a problem hiding this comment.
Mention looking at the MDK Examples repo as applying the plugin alone doesn't fix built jars iirc
| this.report("legacy-missing-renamer", "Missing Renamer Gradle for legacy Minecraft dependency", spec -> spec | ||
| .details(""" | ||
| A legacy Forge dependency was declared, but Renamer Gradle has not been applied to the project! | ||
| While the workspace will continue to function, this may cause problems with resultant artifacts not being renamed to obfuscated mappings. |
Contributor
There was a problem hiding this comment.
Something something "while your mod will work in dev, the built jar won't work in production without the renamer plugin applied and reobf used on it"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name entails. Specifically, display warning if snapshot version (detected by looking for
w) is less than 24w13(a) or main version is less than 1.20.5 (ghost .0 is added to versions such as 1.20).