fix: remediate 9 security findings from external audit (OS-15 through OS-23)#744
Merged
johntmyers merged 10 commits intomainfrom Apr 3, 2026
Merged
fix: remediate 9 security findings from external audit (OS-15 through OS-23)#744johntmyers merged 10 commits intomainfrom
johntmyers merged 10 commits intomainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses 9 findings from the external security audit, delivered as one commit per finding for clean bisect/revert:
tarextraction in install.sh to expected binary (path traversal, CWE-22)serde_jsonfor JS embedding, add CSP header (XSS, CWE-79)serde_yamlwithserde_yml(RUSTSEC-2024-0320, CWE-1104)Related Issues
Closes OS-15, OS-16, OS-17, OS-18, OS-19, OS-20, OS-21, OS-22, OS-23
Changes
721f4bdcinstall.shb8307dc7deploy/docker/cluster-entrypoint.sh77541a11crates/openshell-server/src/ssh_tunnel.rs21646778crates/openshell-server/src/auth.rs3c0d7e8dcrates/openshell-server/src/auth.rs1a961133crates/openshell-sandbox/src/proxy.rsf95590f7crates/openshell-policy/src/lib.rs71329fbd04825ee1crates/openshell-server/src/grpc.rs,crates/openshell-tui/src/lib.rsTesting
cargo fmt --check— cleancargo clippy— clean (pre-existing warnings only)cargo test --workspace— all tests pass (new tests added for code validation and port rejection)mise run pre-commit— all checks pass (only pre-existing license header issue on untracked local file)Checklist