test(bindings): nvjitlink_session for reliable teardown in nvjitlink tests#1852
Open
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Open
test(bindings): nvjitlink_session for reliable teardown in nvjitlink tests#1852rwgk wants to merge 1 commit intoNVIDIA:mainfrom
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Made-with: Cursor
rwgk
added
P2
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick drive-by cleanup.
Wrap
nvjitlink.create/nvjitlink.destroyusage in a small context manager so handles are always destroyed, including when a test fails on an assertion or raises mid-way. This matches the existing pattern intest_nvvm.py(nvvm_program).Why bother: Tests are often copied or used as reference when adding new code. Keeping resource handling explicit and correct in tests helps avoid spreading lower-quality patterns elsewhere.