Add numba-cuda-mlir docs, cuda-core/cuda-cccl deps, cuda-toolkit extras#2101
Add numba-cuda-mlir docs, cuda-core/cuda-cccl deps, cuda-toolkit extras#2101leofang wants to merge 2 commits into
Conversation
… cuda-toolkit extras - Mention numba-cuda-mlir in README.md and DESCRIPTION.rst above the existing numba.cuda entry - Add cuda-core~=1.0.0 and cuda-cccl~=1.0.0 as required dependencies of the cuda-python metapackage (closes NVIDIA#148, closes NVIDIA#691) - Add bare cuda-toolkit==13.* to cuda-bindings[all] and remove cudla from the component-specific extras (closes NVIDIA#903) - Add cuda-toolkit==12.*/13.* to cuda-core's cu12/cu13 extras
| [project.optional-dependencies] | ||
| all = [ | ||
| "cuda-toolkit[nvrtc,nvjitlink,nvvm,nvfatbin,cudla]==13.*", | ||
| "cuda-toolkit[nvrtc,nvjitlink,nvvm,nvfatbin]==13.*", |
There was a problem hiding this comment.
I noticed this change sneaked in from PR #2034. This is a bit problematic because cuDLA is not a universally available component in the CTK, and the majority of users cannot use it but they'd see this at install time:
WARNING: cuda-toolkit 13.1.2.0 does not provide the extra 'cudla'
We should just document that DLA users need to install cuDLA if they haven't already (which I suspect is not the case, because there should be a system CTK already installed on embedded devices).
There was a problem hiding this comment.
I approved this knowingly, after discovering that the meta package has the filters we need.
I missed that warning message though. If we want to get rid of it, we have do add the conditions similar to what we're doing under cuda_pathfinder/pyproject.toml:
"nvidia-cudla; platform_system == 'Linux' and platform_machine == 'aarch64'",
| install_requires=[ | ||
| f"cuda-bindings{matcher}{version}", | ||
| "cuda-core~=1.0.0", | ||
| "cuda-cccl~=1.0.0", |
There was a problem hiding this comment.
To discuss: If we need numba-cuda-mlir here
There was a problem hiding this comment.
What's the argument for adding it?
Summary
README.mdandDESCRIPTION.rst(above the existingnumba.cudaentry)cuda-core~=1.0.0andcuda-cccl~=1.0.0as required dependencies of thecuda-pythonmetapackage (closes Addcuda-coreas a required dependency tocuda-python#148, closes Addcuda-ccclas a required dependency tocuda-python#691)cuda-toolkit==13.*tocuda-bindings[all]and removecudlafrom the component-specific extras (closes RFC: Make ourcuda-*packages depend on the newcuda-toolkitmetapackage without version constraints? #903)cuda-toolkit==12.*/cuda-toolkit==13.*tocuda-core'scu12/cu13extras