Backport #1972 to 12.9.x#2206
Merged
Merged
Conversation
…IDIA#1972) * Move driver and nvrtc cython and internal layers to new generator * Fix Cython interop tests * Handle headers differently * Fix compilation * Make const match * Fix compilation again * Attempt to fix Windows build * Fix Windows again * Fix not found error code * Look up pointers in a different way * Get first version right * Get first appearing versions correct * Fix weird special case * Fix exception signature to match what was there before * Also fix exception declaration in nvrtc * Fix PTDS and add PTDS testing * Update .gitignore Co-authored-by: Leo Fang <leof@nvidia.com> --------- Co-authored-by: Leo Fang <leof@nvidia.com>
Member
Contributor
Author
Yes. Unfortunately, a bunch of things broke when not running through all of the headers in cybind (as would happen when trying to regenerate this). I'm close to a fix, but I should have done this work before merging #1972 because it turns out this backport use case is a lot harder than I expected. |
Contributor
Author
Contributor
Author
|
@leofang: This is passing now and ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.