Skip to content

Add cmake-format#409

Merged
pelesh merged 3 commits into
developfrom
nicholson/cmake-format
Jun 1, 2026
Merged

Add cmake-format#409
pelesh merged 3 commits into
developfrom
nicholson/cmake-format

Conversation

@nkoukpaizan
Copy link
Copy Markdown
Collaborator

@nkoukpaizan nkoukpaizan commented May 20, 2026

Description

This add cmake-format hooks to harmonize CMake files.

I noticed the need for manual formatting in #394. I thought we had added this at the same time as Re::Solve, but it must have slipped through the cracks.

Proposed changes

  • Added .cmake-format.py. I tried to match the existing style as much as possible.
  • Added cmake-format hook to .pre-commit-config.yaml.
  • CI should modify CMake files accordingly.

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [N/A] The new code follows GridKit™ style guidelines.
  • [N/A] There are unit tests for the new code.
  • [n/A] The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

Formatting-only changes.

@nkoukpaizan nkoukpaizan self-assigned this May 20, 2026
@nkoukpaizan nkoukpaizan added development Features/Tools related to development of GridKit, rather than use as a library. cmake labels May 20, 2026
@nkoukpaizan nkoukpaizan force-pushed the nicholson/cmake-format branch 14 times, most recently from c28049e to a32e319 Compare May 20, 2026 21:23
Comment thread application/PhasorDynamics/CMakeLists.txt Outdated
@nkoukpaizan nkoukpaizan force-pushed the nicholson/cmake-format branch 8 times, most recently from ca7fa5f to 4316bbf Compare May 21, 2026 14:30
@nkoukpaizan nkoukpaizan requested a review from pelesh May 21, 2026 14:34
@nkoukpaizan nkoukpaizan marked this pull request as ready for review May 21, 2026 14:34
@nkoukpaizan nkoukpaizan force-pushed the nicholson/cmake-format branch from 7adbfce to 1e1543e Compare May 28, 2026 22:09
@nkoukpaizan nkoukpaizan reopened this May 28, 2026
Copy link
Copy Markdown
Collaborator

@PhilipFackler PhilipFackler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement. Looks great!

@pelesh pelesh merged commit cc353ec into develop Jun 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake development Features/Tools related to development of GridKit, rather than use as a library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants