Skip to content

Improve Hindi translations for scan comparison messages#1479

Open
Vineshnayak wants to merge 2 commits intoOWASP:masterfrom
Vineshnayak:master
Open

Improve Hindi translations for scan comparison messages#1479
Vineshnayak wants to merge 2 commits intoOWASP:masterfrom
Vineshnayak:master

Conversation

@Vineshnayak
Copy link
Copy Markdown

Proposed change

Improved existing Hindi translations for scan comparison-related messages to make them clearer and more consistent.

Type of change

  • Documentation/localization improvement

Checklist

  • I've followed the contributing guidelines
  • I confirm that the code and comments are my own work

Updated Hindi translations for scan comparison-related messages to improve clarity and consistency.

Signed-off-by: Vinesh nayak <vineshnayak.jatothu@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b6730682-92fc-4c9c-bcef-81a44b87915a

📥 Commits

Reviewing files that changed from the base of the PR and between f0457a6 and e13a758.

📒 Files selected for processing (1)
  • nettacker/locale/hi.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • nettacker/locale/hi.yaml

Summary by CodeRabbit

  • Documentation
    • Updated Hindi localization for scan comparison: improved wording, standardized placeholders (e.g., "compare report saved" message), and refined formatting for comparison results and notifications.

Walkthrough

Updated Hindi localization entries in nettacker/locale/hi.yaml: four compare-scans-related strings were changed to quoted values, one placeholder format adjusted, and the file newline at end was fixed. No code or API signatures were modified.

Changes

Cohort / File(s) Summary
Hindi Localization Strings
nettacker/locale/hi.yaml
Converted compare_scans, compare_report_path_filename, no_scan_to_compare, compare_report_saved to quoted YAML values; adjusted compare_report_saved placeholder to तुलना परिणाम {0} में सहेजे गए; fixed end-of-file newline.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly describes the main change: improving Hindi translations for scan comparison messages, which matches the primary focus of the changeset in nettacker/locale/hi.yaml.
Description check ✅ Passed The description is related to the changeset, accurately identifying the PR as a localization improvement for Hindi scan comparison messages and confirming author's compliance with contribution guidelines.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
nettacker/locale/hi.yaml (1)

120-125: @Vineshnayak please ensure all commits are signed before merge

Reminder: this PR will fail pre-merge checks if any commit is unsigned. Please sign commits (GPG or SSH), then amend/rebase and push updated signed commits.

Quick setup:

  • git config --global commit.gpgsign true
  • git config --global user.signingkey <your-key-id>
  • Re-sign commit(s): git commit --amend -S (or interactive rebase for older commits), then force-push.

Based on learnings: “When reviewing any pull request in the OWASP/Nettacker repository, always remind the PR author to use signed commits and explicitly state that the PR fails pre-merge checks if any commits are unsigned. Tag the author by username and provide instructions on how to sign commits.”

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@nettacker/locale/hi.yaml` around lines 120 - 125, The reviewer reminder text
was accidentally added to the PR file; remove the reviewer/meta instructions and
ensure nettacker/locale/hi.yaml contains only the translation keys (e.g.,
compare_scans, compare_report_path_filename, no_scan_to_compare,
compare_report_saved, build_compare_report, finish_build_report) with their
correct values, then sign your commits (use git commit --amend -S or an
interactive rebase to re-sign older commits) and force-push the cleaned, signed
commits so the pre-merge checks pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@nettacker/locale/hi.yaml`:
- Line 120: The Hindi help string for the key compare_scans is grammatically
awkward; update the value for compare_scans in nettacker/locale/hi.yaml to
"वर्तमान स्कैन की तुलना पुराने स्कैन से करें" to correct the phrasing while
preserving the key name compare_scans.

---

Nitpick comments:
In `@nettacker/locale/hi.yaml`:
- Around line 120-125: The reviewer reminder text was accidentally added to the
PR file; remove the reviewer/meta instructions and ensure
nettacker/locale/hi.yaml contains only the translation keys (e.g.,
compare_scans, compare_report_path_filename, no_scan_to_compare,
compare_report_saved, build_compare_report, finish_build_report) with their
correct values, then sign your commits (use git commit --amend -S or an
interactive rebase to re-sign older commits) and force-push the cleaned, signed
commits so the pre-merge checks pass.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2fcd22ca-b5ee-4fce-ae5b-32dabc79547a

📥 Commits

Reviewing files that changed from the base of the PR and between f4c1bbf and f0457a6.

📒 Files selected for processing (1)
  • nettacker/locale/hi.yaml

Signed-off-by: Vinesh nayak <vineshnayak.jatothu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant