Improve Hindi translations for scan comparison messages#1479
Improve Hindi translations for scan comparison messages#1479Vineshnayak wants to merge 2 commits intoOWASP:masterfrom
Conversation
Updated Hindi translations for scan comparison-related messages to improve clarity and consistency. Signed-off-by: Vinesh nayak <vineshnayak.jatothu@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughUpdated Hindi localization entries in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
nettacker/locale/hi.yaml (1)
120-125: @Vineshnayak please ensure all commits are signed before mergeReminder: this PR will fail pre-merge checks if any commit is unsigned. Please sign commits (GPG or SSH), then amend/rebase and push updated signed commits.
Quick setup:
git config --global commit.gpgsign truegit config --global user.signingkey <your-key-id>- Re-sign commit(s):
git commit --amend -S(or interactive rebase for older commits), then force-push.Based on learnings: “When reviewing any pull request in the OWASP/Nettacker repository, always remind the PR author to use signed commits and explicitly state that the PR fails pre-merge checks if any commits are unsigned. Tag the author by username and provide instructions on how to sign commits.”
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@nettacker/locale/hi.yaml` around lines 120 - 125, The reviewer reminder text was accidentally added to the PR file; remove the reviewer/meta instructions and ensure nettacker/locale/hi.yaml contains only the translation keys (e.g., compare_scans, compare_report_path_filename, no_scan_to_compare, compare_report_saved, build_compare_report, finish_build_report) with their correct values, then sign your commits (use git commit --amend -S or an interactive rebase to re-sign older commits) and force-push the cleaned, signed commits so the pre-merge checks pass.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@nettacker/locale/hi.yaml`:
- Line 120: The Hindi help string for the key compare_scans is grammatically
awkward; update the value for compare_scans in nettacker/locale/hi.yaml to
"वर्तमान स्कैन की तुलना पुराने स्कैन से करें" to correct the phrasing while
preserving the key name compare_scans.
---
Nitpick comments:
In `@nettacker/locale/hi.yaml`:
- Around line 120-125: The reviewer reminder text was accidentally added to the
PR file; remove the reviewer/meta instructions and ensure
nettacker/locale/hi.yaml contains only the translation keys (e.g.,
compare_scans, compare_report_path_filename, no_scan_to_compare,
compare_report_saved, build_compare_report, finish_build_report) with their
correct values, then sign your commits (use git commit --amend -S or an
interactive rebase to re-sign older commits) and force-push the cleaned, signed
commits so the pre-merge checks pass.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 2fcd22ca-b5ee-4fce-ae5b-32dabc79547a
📒 Files selected for processing (1)
nettacker/locale/hi.yaml
Signed-off-by: Vinesh nayak <vineshnayak.jatothu@gmail.com>
Proposed change
Improved existing Hindi translations for scan comparison-related messages to make them clearer and more consistent.
Type of change
Checklist