Skip to content

Fix translation for compare_scans message#1480

Open
Vineshnayak wants to merge 1 commit intoOWASP:masterfrom
Vineshnayak:patch-1
Open

Fix translation for compare_scans message#1480
Vineshnayak wants to merge 1 commit intoOWASP:masterfrom
Vineshnayak:patch-1

Conversation

@Vineshnayak
Copy link
Copy Markdown

Proposed change

Improved Hindi translations for scan comparison-related messages and fixed minor grammar issues.

Type of change

  • Documentation/localization improvement

Checklist

  • I've followed the contributing guidelines
  • I confirm that the code and comments are my own work

Signed-off-by: Vinesh nayak <vineshnayak.jatothu@gmail.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

Summary by CodeRabbit

  • Localization
    • Updated Hindi translation text for the scan comparison feature with refined wording
    • Fixed file formatting

Walkthrough

Updated Hindi localization text for the compare_scans key in the locale file. The translation was modified with revised wording and YAML formatting adjustments, including quote marks and a newline at file end.

Changes

Cohort / File(s) Summary
Localization Update
nettacker/locale/hi.yaml
Updated Hindi translation for compare_scans key with revised wording (word order adjusted). Added quote marks around the translation string and ensured file ends with newline character.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • arkid15r
  • securestep9
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title accurately describes the main change: fixing the Hindi translation for the compare_scans localization message with improved wording and proper formatting.
Description check ✅ Passed The PR description is directly related to the changeset, explaining that it involves improved Hindi translations for scan comparison messages and minor grammar fixes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@nettacker/locale/hi.yaml`:
- Around line 120-125: The commits that modified the locale keys (compare_scans,
compare_report_path_filename, no_scan_to_compare, compare_report_saved,
build_compare_report, finish_build_report) are unsigned and must be GPG-signed
before merging; fix this by signing the commit(s) (e.g., run git commit --amend
-S for the latest commit or use git rebase --exec 'git commit --amend -S
--no-edit' origin/master to sign multiple commits), then push the rewritten
history with git push --force-with-lease so the pre-merge checks pass.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a3229f10-43b3-4228-90dc-edcf6e2179e2

📥 Commits

Reviewing files that changed from the base of the PR and between f4c1bbf and 650d568.

📒 Files selected for processing (1)
  • nettacker/locale/hi.yaml

Comment on lines +120 to +125
compare_scans: "scan_id का उपयोग करके वर्तमान स्कैन की तुलना पुराने स्कैन से करें"
compare_report_path_filename: तुलना रिपोर्ट सहेजने का फ़ाइल पथ
no_scan_to_compare: तुलना करने के लिए scan_id नहीं मिला
compare_report_saved: "{0} में तुलना परिणाम सहेजे गए"
build_compare_report: "तुलना रिपोर्ट बनाई जा रही है"
finish_build_report: "तुलना रिपोर्ट तैयार हो गई" No newline at end of file
finish_build_report: "तुलना रिपोर्ट तैयार हो गई"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify signature status for commits in this PR branch vs master
git log --pretty=format:'%h %G? %an %s' origin/master..HEAD

# Expected: signed commits (typically G/U depending on trust state).
# Investigate any N/B/E/X/Y/R statuses as unsigned/invalid signatures.

Repository: OWASP/Nettacker

Length of output: 189


All commits in this PR must be GPG signed before merge.

@Vineshnayak: The commit in this PR is currently unsigned. This PR will fail pre-merge checks and cannot be merged until you sign the commit(s).

To fix this:

  1. Sign the commit: git commit --amend -S
  2. Force-push the updated history: git push --force-with-lease

Alternatively, if you have multiple unsigned commits, you can use an interactive rebase to sign them all:

git rebase --exec 'git commit --amend -S --no-edit' origin/master
git push --force-with-lease

Signed commits are a mandatory requirement in this repository.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@nettacker/locale/hi.yaml` around lines 120 - 125, The commits that modified
the locale keys (compare_scans, compare_report_path_filename,
no_scan_to_compare, compare_report_saved, build_compare_report,
finish_build_report) are unsigned and must be GPG-signed before merging; fix
this by signing the commit(s) (e.g., run git commit --amend -S for the latest
commit or use git rebase --exec 'git commit --amend -S --no-edit' origin/master
to sign multiple commits), then push the rewritten history with git push
--force-with-lease so the pre-merge checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant