Skip to content

Fix VC++ dependency requirement on windows hosts#13

Merged
eddymoulton merged 11 commits into
octopus/masterfrom
octopus/em/static-win
Jun 5, 2026
Merged

Fix VC++ dependency requirement on windows hosts#13
eddymoulton merged 11 commits into
octopus/masterfrom
octopus/em/static-win

Conversation

@eddymoulton
Copy link
Copy Markdown
Collaborator

@eddymoulton eddymoulton commented Jun 4, 2026

When implementing #8, we accidentally lent on VC++ being installed on Windows hosts which wasn't picked up because it is often pre-installed.

This change:

  • Splits the build up into win, linux and mac jobs so we get a faster feedback loop
  • Modifies the windows build to generate a static binary that includes libssh2 + further dependencies
  • Adds a smoke test to ensure that the windows (and linux) binaries are able to be loaded on images that do not have pre-installed prerequisites.
    • Before the fix was applied, I confirmed the smoke test fails

I'll come back and make the same change for openssl3 linux builds too but for now this is blocking a windows release.
The Linux change will involve more testing, so best not to rush it.

Relates to MD-2027

@eddymoulton eddymoulton changed the title Add smoke test for windows to replicate the issue Fix VC++ dependency requirement on windows hosts Jun 4, 2026
Comment thread build.libgit2.ps1
Comment on lines +189 to +190
'-D', 'CMAKE_SHARED_LINKER_FLAGS=bcrypt.lib crypt32.lib'
'-D', 'HAVE_LIBSSH2_MEMORY_CREDENTIALS=1'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two properties are new

@eddymoulton eddymoulton marked this pull request as ready for review June 5, 2026 03:06
@eddymoulton eddymoulton merged commit 23fae9b into octopus/master Jun 5, 2026
21 checks passed
@eddymoulton eddymoulton deleted the octopus/em/static-win branch June 5, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants