Fix VC++ dependency requirement on windows hosts#13
Merged
Conversation
eddymoulton
commented
Jun 5, 2026
Comment on lines
+189
to
+190
| '-D', 'CMAKE_SHARED_LINKER_FLAGS=bcrypt.lib crypt32.lib' | ||
| '-D', 'HAVE_LIBSSH2_MEMORY_CREDENTIALS=1' |
Collaborator
Author
There was a problem hiding this comment.
These two properties are new
evolutionise
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When implementing #8, we accidentally lent on VC++ being installed on Windows hosts which wasn't picked up because it is often pre-installed.
This change:
I'll come back and make the same change for openssl3 linux builds too but for now this is blocking a windows release.
The Linux change will involve more testing, so best not to rush it.
Relates to MD-2027