feat: add pre-write immutability filter for private datasets on enclave#9418
Open
rasswanth-s wants to merge 2 commits into
Open
feat: add pre-write immutability filter for private datasets on enclave#9418rasswanth-s wants to merge 2 commits into
rasswanth-s wants to merge 2 commits into
Conversation
Prevents overwrites/deletes of private dataset files once they exist on the enclave filesystem, ensuring data integrity between share and job execution. (cherry picked from commit 1d7c295e7522b1631a9792f0e10daafd8d3081e5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pre_write_filterhook toDataSiteWatcherCachethat gates every file write/delete inapply_event_message()make_private_dataset_immutability_filter()in the enclave package — blocks overwrites/deletes of private dataset files that already exist on diskSyftEnclaveClient.from_config()so all enclave instances enforce immutability automaticallyThreat addressed: Once a DO shares private dataset files with the enclave, subsequent re-sends or sync cycles cannot overwrite them — ensuring the data the enclave computes on remains the same as what was originally delivered.
Test plan
is_private_dataset_path()(positive, public path, wrong subdir, too short)