Skip to content

Restore properties after encryption to support them being reused#713

Merged
andreasohlund merged 7 commits intomasterfrom
restore-values-after-encryption
Apr 10, 2026
Merged

Restore properties after encryption to support them being reused#713
andreasohlund merged 7 commits intomasterfrom
restore-values-after-encryption

Conversation

@andreasohlund
Copy link
Copy Markdown
Member

@andreasohlund andreasohlund commented Apr 8, 2026

Copy link
Copy Markdown

@rbev rbev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the one small question

Comment thread src/MessageProperty/EncryptBehavior.cs Outdated
Comment thread src/MessageProperty/EncryptBehavior.cs Outdated
Comment thread src/MessageProperty/EncryptBehavior.cs Outdated
Comment thread src/AcceptanceTests/When_message_or_sub_properties_are_reused_unobtrusive.cs Outdated
Comment thread src/AcceptanceTests/When_message_or_sub_properties_are_reused_unobtrusive.cs Outdated
@andreasohlund andreasohlund requested a review from tmasternak April 8, 2026 11:46
@andreasohlund andreasohlund marked this pull request as ready for review April 8, 2026 11:46
@andreasohlund
Copy link
Copy Markdown
Member Author

@tmasternak changes to the tests are now pushed, please review

@andreasohlund andreasohlund dismissed tmasternak’s stale review April 10, 2026 06:51

changes addressed

@andreasohlund andreasohlund merged commit 79ff688 into master Apr 10, 2026
4 checks passed
@andreasohlund andreasohlund deleted the restore-values-after-encryption branch April 10, 2026 06:51
rbev pushed a commit that referenced this pull request Apr 14, 2026
* Restore properties after encryption to support reuse

* Switch to new tuple syntax

* Better name

* Use existing tests instead

* Add test to check correctness when sending the same object multiple times

* Minimize diff revert EOF changes

* Test both supported variants

---------

Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
andreasohlund added a commit that referenced this pull request Apr 14, 2026
… (#716)

* Restore properties after encryption to support reuse

* Switch to new tuple syntax

* Better name

* Use existing tests instead

* Add test to check correctness when sending the same object multiple times

* Minimize diff revert EOF changes

* Test both supported variants

---------

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
rbev pushed a commit that referenced this pull request Apr 15, 2026
* Restore properties after encryption to support reuse

* Switch to new tuple syntax

* Better name

* Use existing tests instead

* Add test to check correctness when sending the same object multiple times

* Minimize diff revert EOF changes

* Test both supported variants

---------

Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
andreasohlund added a commit that referenced this pull request Apr 15, 2026
… (#718)

* Restore properties after encryption to support reuse

* Switch to new tuple syntax

* Better name

* Use existing tests instead

* Add test to check correctness when sending the same object multiple times

* Minimize diff revert EOF changes

* Test both supported variants

---------

Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants