fix(sessions): shrink resource chips and handle overflow#2619
Open
adboio wants to merge 1 commit into
Open
Conversation
|
React Doctor could not complete this scan.
Reviewed by React Doctor for commit |
Contributor
|
Reviews (1): Last reviewed commit: "fix(sessions): shrink resource chips and..." | Re-trigger Greptile |
Shrink the "PostHog resources used" chips so they sit better with nearby UI: label/badge text 12px -> 11px, chip icons 12 -> 11, gap 2 -> 1. Handle long lists gracefully: collapse chips past a max behind a "+N more" toggle, truncate long labels, and clip the row so the bar can never blow out above the composer. Generated-By: PostHog Code Task-Id: c51a17de-d847-49bc-aa12-3798ca33288d
c9fb62f to
e240eb2
Compare
Contributor
|
Reviews (2): Last reviewed commit: "fix(sessions): shrink resource chips and..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The "PostHog resources used" chips above the composer were a bit too large relative to the surrounding UI, and a long list of resources had no graceful handling — it could wrap across multiple rows and crowd the composer.
Why: Direct feedback from Michael that the bar "is really nice btw, although the buttons and text are a bit too large relative to the UI nearby" — plus a request to handle the case where there are too many chips and they might overflow.
Changes
12px→11px, chip icons12→11, inter-chip gap2→1.+N morebadge that toggles toShow less, long labelstruncate, and the row is clipped so it can never push wider than the chat content width.PlanStatusBar).How did you test this?
biome linton the changed file — clean.pnpm build(full topological build) succeeded, thenpnpm --filter @posthog/ui typecheck— no errors in the changed file.Automatic notifications
Created with PostHog Code from a Slack thread