fix(pulseaudio): use device names as id#1228
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PulseAudio backend to produce stable, meaningful DeviceIds by using the PulseAudio sink/source names rather than their transient numeric indexes, addressing unstable IDs (notably for Bluetooth devices) reported in #1227.
Changes:
- Change PulseAudio
DeviceTrait::id()to useinfo.name(e.g.alsa_output.*,bluez_output.*) instead ofinfo.index. - Update
Deviceequality and hashing to be based oninfo.namerather thaninfo.index. - Adjust
DeviceTrait::description()to prefer the human-friendly PulseAudiodescriptionas the display name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New output:
Old output:
Fixes #1227