Add set_channel function for MidiMessage#24
Merged
wmedrano merged 1 commit intoRustAudio:mainfrom Apr 18, 2026
Merged
Conversation
wmedrano
approved these changes
Mar 31, 2026
Contributor
Author
|
You approved this PR but did not merge. Is there still something missing from my side? |
Member
|
I don't rememeber 😖 Merged! |
Member
|
This should be live in v4.0.11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to separately set the channel for a message is useful when processing messages for routing or creating layered sounds.
Ideally, the method would return a result with an error in case of system messages, but that would require a new dedicated error type. I'm not sure if it's worth do implement this.