Skip to content

feat: [Batch]#850

Merged
CharlesDuboisSAP merged 34 commits into
mainfrom
batch
May 18, 2026
Merged

feat: [Batch]#850
CharlesDuboisSAP merged 34 commits into
mainfrom
batch

Conversation

@CharlesDuboisSAP
Copy link
Copy Markdown
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented May 6, 2026

Context

New module, new API

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this May 6, 2026
@CharlesDuboisSAP CharlesDuboisSAP added the please-review Request to review a pull-request label May 6, 2026
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this is more than a PoC. Looks like it could be released.

@jjtang1985 What do you think regarding releasing this?

Comment thread core-services/batch/pom.xml Outdated
Comment thread sample-code/spring-app/src/main/resources/static/index.html Outdated
CharlesDuboisSAP and others added 9 commits May 7, 2026 16:05
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
Comment thread core-services/batch/pom.xml
Copy link
Copy Markdown
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

rpanackal
rpanackal previously approved these changes May 13, 2026
Copy link
Copy Markdown
Member

@rpanackal rpanackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/release_notes.md Outdated
CharlesDuboisSAP and others added 3 commits May 13, 2026 16:28
… through an error message'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, only minor comments.

Comment thread .github/workflows/spec-update.yaml
Comment thread docs/release_notes.md Outdated
### ✨ New Functionality

- [Orchestration] Added `GEMINI_3_1_FLASH_LITE` to model list in `OrchestrationAiModel`.
- [Batch] Added a new `BatchesApi` client to access the [Batch Service API](https://help.sap.com/docs/SAP_FIELD_SERVICE_MANAGEMENT/fsm_data_api/batch-api-intro.html).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Minor)

This is a wrong link I fear. This links to SAP Field Service Managements batch api...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced with link their repo, they don't have docs

CharlesDuboisSAP and others added 2 commits May 18, 2026 15:44
Co-authored-by: Jonas-Isr <jonas.israel@sap.com>
@CharlesDuboisSAP CharlesDuboisSAP enabled auto-merge (squash) May 18, 2026 13:48
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@CharlesDuboisSAP CharlesDuboisSAP merged commit 7d569fb into main May 18, 2026
6 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the batch branch May 18, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

please-review Request to review a pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants