Skip to content

fix: [DevOps] Run compile and test even if api compatibility test fails #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rpanackal wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

fix: [DevOps] Run compile and test even if api compatibility test fails #869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/spec-update.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,9 +273,6 @@ jobs:
echo "api_compat_result=compatible" >> "$GITHUB_OUTPUT"
else
echo "api_compat_result=incompatible" >> "$GITHUB_OUTPUT"
echo "## ❌ API Compatibility: Breaking changes detected" >> $GITHUB_STEP_SUMMARY
echo "Download the **japicmp-report** artifact for details." >> $GITHUB_STEP_SUMMARY
exit 1
fi

- name: 'Upload japicmp report'
Expand Down Expand Up @@ -386,6 +383,12 @@ jobs:
echo "Client generation failed. Please check the Generate step logs for details."
exit 1

- name: 'Fail if API incompatible'
if: steps.api_compat.outputs.api_compat_result == 'incompatible'
run: |
echo "API compatibility check detected breaking changes. Download the japicmp-report artifact for details."
Copy link
Copy Markdown
Member

@Jonas-Isr Jonas-Isr May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Minor)

Where would we find the artifact? Is there a way to provide a useful link here for convenience?

exit 1

- name: 'Fail if no spec changes and previous run failed'
if: steps.spec_diff.outputs.prev_run_success == 'false' && github.event.inputs.is-weekly != 'true'
run: |
Expand Down