Exit 0 when queue is exhausted after lazy-load boot#386
Open
Conversation
In lazy-load mode, the queue.exhausted? check runs before the app boots. Slow workers can finish booting after the queue has been fully drained by faster workers -- at that point Minitest.run [] finds nothing to run and returns false, causing the worker to exit 1. Add a second exhausted? check immediately before Minitest.run []. If the queue is already drained at that point, print the existing "All tests were ran already" message and exit 0 instead of propagating a false failure to Buildkite. Bump version to 0.86.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lazy-load mode, the
queue.exhausted?check runs before the app boots (runner.rb:96). Slow workers can finish booting after the queue has been fully drained by faster workers -- at that pointMinitest.run []finds nothing to run and returns false, causing the worker to exit 1 and Buildkite to mark the job failed.This was observed on the
areas-core-storefront-liquid-vm-compile-jsonpipeline where 49 workers boot in parallel. Boot time ranges from 138s to 452s due to CPU contention; the queue drains in ~418s. Workers that boot past that point get 0 tests and spuriously fail.Add a second
exhausted?check immediately beforeMinitest.run []. If the queue is already drained at that point, print "All tests were ran already" and exit 0.Bump version to 0.86.0.