fix: lazy_load silently breaking queues without stream_populate#400
Open
andheiberg wants to merge 1 commit into
Open
fix: lazy_load silently breaking queues without stream_populate#400andheiberg wants to merge 1 commit into
andheiberg wants to merge 1 commit into
Conversation
When lazy_load=true but the queue does not implement stream_populate (e.g. CI::Queue::Bisect), load_tests skipped requiring test files, leaving Minitest.loaded_tests empty. populate_queue then called queue.populate([]), so Bisect#failing_test_present? always returned nil, causing the bisect runner to exit with "The failing test does not exist." despite the test being a valid, runnable test. Fix: only skip eager file loading when the queue actually supports stream_populate. When it does not, fall through to the eager path so Minitest.loaded_tests is populated before populate is called.
andheiberg
changed the title
andheiberg
changed the title
robinmoneybird
pushed a commit
to robinmoneybird/ci-queue
that referenced
this pull request
Jun 16, 2026
Bisect currently exits 1 in two cases that represent successful
diagnostic runs rather than failures:
1. "The bisection was inconclusive, there might not be any leaky
test here." - the bisect ran, narrowed candidates, and the
failure did not reproduce on the final narrowed order. This is
the expected outcome for genuinely flaky tests (timing, async,
network) rather than order-dependent ones.
2. "The failing test was the first test in the test order so there
is nothing to bisect." - the bisect ran and reported that there
are no preceding tests to suspect.
Both are valid findings produced by a successful run. Treating them as
build failures forces callers (e.g. CI pipelines that invoke bisect on
flaky tests) to permanently sit at a low pass rate even though bisect
is doing exactly what it is supposed to do, and makes it impossible to
distinguish these outcomes from real harness failures like the one
fixed in Shopify#400 (lazy_load leaving Minitest.loaded_tests empty so the
failing test could not be found).
After this change:
exit 0 - bisect ran to completion (polluter found, inconclusive,
failing test failed in isolation, or nothing to bisect)
exit 1 - bisect could not run (FAILING_TEST not present in the
queue, missing arguments, etc.)
Tests are updated to assert the contract for each scenario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When lazy_load=true but the queue does not implement stream_populate (e.g. CI::Queue::Bisect), load_tests skipped requiring test files, leaving Minitest.loaded_tests empty. populate_queue then called queue.populate([]), so Bisect#failing_test_present? always returned nil, causing the bisect runner to exit with "The failing test does not exist." despite the test being a valid, runnable test.
Fix: only skip eager file loading when the queue actually supports stream_populate. When it does not, fall through to the eager path so Minitest.loaded_tests is populated before populate is called.