Conversation
There was a problem hiding this comment.
Pull request overview
Adds two repo-local CI “skills” (pre-submit guidance and CI triage) for Shopify CLI agents, plus shared repo-contract notes, and repoints .claude/skills to the new canonical .agents/skills location.
Changes:
- Add
cli-pre-submit-ciskill to derive minimal pre-submit checks from workflow/dev.yml/package.json contracts. - Add
cli-ci-triageskill to map broad CI failures to the real failing job/shard and recommend a single next action. - Add shared
_shared/shopify-cli-ci-repo-contracts.mdand point.claude/skillsat.agents/skillsfor compatibility.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| .claude/skills | Compatibility pointer intended to route skills lookup to .agents/skills. |
| .agents/skills/cli-pre-submit-ci/SKILL.md | New pre-submit guidance skill focused on minimal checks + staging guidance. |
| .agents/skills/cli-ci-triage/SKILL.md | New CI triage skill with GH CLI workflow-to-job drilldown and classification. |
| .agents/skills/_shared/shopify-cli-ci-repo-contracts.md | Shared repo-specific CI contract facts referenced by both skills. |
Comments suppressed due to low confidence (1)
.claude/skills:1
- PR description says this is a compatibility symlink. Please ensure this is committed as an actual symlink (git mode 120000) rather than a regular text file containing the target path; otherwise consumers that expect a symlink may not follow it correctly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Situation | Default response | | ||
| |---|---| | ||
| | User is at PR time (`submit`, `open`, `update`, `restack`) | advisory mode: suggest minimal checks, staging needs, and likely CI risk; ask before running anything substantial | | ||
| | User asks what to run before push | recommend the minimal high-signal checks implied by the workflow | | ||
| | User asks what to commit or stage | reproduce the relevant generator/check path, then inspect git status and diffs | | ||
| | User explicitly asks to run checks | run the minimal derived set, not the whole world | |
There was a problem hiding this comment.
The markdown table rows are written with double leading pipes (|| ...). On GitHub this renders as an extra empty column (or otherwise malformed table). Use standard pipe table syntax with a single leading pipe per row (e.g., | Situation | Default response |).
| | Class | Signal | Next action | | ||
| |---|---|---| | ||
| | Generated artifact drift | cleanliness assertion after generation; diff-only failure | reproduce the exact generator locally, inspect/stage output | | ||
| | Static check failure | lint, type-check, bundle, knip, schema freshness | run the exact local contract and fix deterministically | | ||
| | Aggregate/gate failure | visible failed check depends on other jobs | drill into the underlying failed job first | | ||
| | Deterministic test failure | same file/test fails repeatedly on completed runs | reproduce or narrow locally, then push a code/test fix | | ||
| | Likely flake | isolated shard failure with weak repetition or infra smell | recommend rerun or focused investigation before broad conclusions | | ||
| | Queue/cancellation noise | cancelled runs or long wait before job start | explain that this is not necessarily execution slowness or product failure | |
There was a problem hiding this comment.
Same issue as the other skill: the tables use || which typically renders as an extra empty column / malformed table in GitHub Markdown. Switch to standard |-delimited table rows (single leading pipe).
| | Situation | Default advice | | ||
| |---|---| | ||
| | same file/test/check fails repeatedly on completed runs | push a fix | | ||
| | failure is isolated and weakly reproducible | rerun or investigate further | | ||
| | current run is still in progress and earlier runs were cancelled | wait | | ||
| | workflow contract is clearly unmet | push a fix | |
There was a problem hiding this comment.
Same issue as the other skill: the tables use || which typically renders as an extra empty column / malformed table in GitHub Markdown. Switch to standard |-delimited table rows (single leading pipe).
dmerand
force-pushed
the
dlm-cli-ci-skills
branch
from
eab4323 to
221b97b
Compare
dmerand
force-pushed
the
dlm-cli-ci-skills
branch
from
221b97b to
76cd34d
Compare
ryancbahan
left a comment
ryancbahan
left a comment
There was a problem hiding this comment.
i'm open to trying this and seeing if it helps.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
What
Add repo-local CI guidance under
.agents/skills/for Shopify CLI:cli-pre-submit-ci_shared/shopify-cli-ci-repo-contracts.mdAlso point
.claude/skillsat.agents/skills.Why
Agents working in this repo keep rediscovering the same pre-submit CI behavior:
This change preserves the high-value pre-submit guidance in a reusable repo-local skill without over-encoding CI triage that the model can usually infer on its own.
How
dev.yml,package.json, and helper scripts_shared/shopify-cli-ci-repo-contracts.md.agents/skillsas the canonical in-repo location and keep.claude/skillsas a compatibility symlink