Skip to content

[Refactor] Simplify tryParseInt utility #7560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

[Refactor] Simplify tryParseInt utility #7560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/cli-kit/src/public/common/string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,14 +234,9 @@ export function pluralize<
* @returns The int if it was able to convert, otherwise undefined.
*/
export function tryParseInt(maybeInt: string | undefined): number | undefined {
let asInt: number | undefined
if (maybeInt !== undefined) {
asInt = parseInt(maybeInt, 10)
if (isNaN(asInt)) {
asInt = undefined
}
}
return asInt
if (maybeInt === undefined) return undefined
const asInt = Number.parseInt(maybeInt, 10)
return Number.isNaN(asInt) ? undefined : asInt
}

/**
Expand Down
Loading