[Tests] Remove filesystem mocks in function common.test.ts#7567
[Tests] Remove filesystem mocks in function common.test.ts#7567gonzaloriestra wants to merge 1 commit into
Conversation
Refactor `packages/app/src/cli/services/function/common.test.ts` to remove global filesystem mocks. Updated `getOrGenerateSchemaPath` tests to use `inTemporaryDirectory` and real filesystem operations. The `generateSchemaService` mock now writes files to disk to satisfy the `fileExists` checks within the service. This makes the tests more robust and representative of actual behavior.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
Goals 🎯
Replace fragile filesystem mocks with real temporary directories in
packages/app/src/cli/services/function/common.test.ts.Changes 🛠
vi.mock('@shopify/cli-kit/node/fs').getOrGenerateSchemaPathtests to useinTemporaryDirectory.generateSchemaServicemock implementation to write a realschema.graphqlfile to the temporary directory.How to test your changes? 🧪
CI
PR created automatically by Jules for task 2974459126850071803 started by @gonzaloriestra