[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7604
[Tests] Remove filesystem mocks in execute-command-helpers.test.ts#7604gonzaloriestra wants to merge 1 commit into
Conversation
Replace global vi.mock('@shopify/cli-kit/node/fs') with real filesystem operations using inTemporaryDirectory and writeFile. This ensures that the tests for prepareExecuteContext verify actual behavior when reading and validating GraphQL query files.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The tests for
prepareExecuteContextwere using filesystem mocks, which test implementation details (that certain functions were called) rather than behavior (that the query is correctly read and validated).WHAT is this pull request doing?
Refactors
packages/app/src/cli/utilities/execute-command-helpers.test.tsto remove the global mock of@shopify/cli-kit/node/fs. It usesinTemporaryDirectoryandwriteFileto create real files for testing the--query-fileflag logic.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 4749985076809950236 started by @gonzaloriestra