Translate clip paths for text with RenderLocation. #399
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #399 +/- ##
===================================
- Coverage 86% 86% -1%
===================================
Files 109 109
Lines 9052 9058 +6
Branches 1085 1087 +2
===================================
+ Hits 7820 7825 +5
Misses 982 982
- Partials 250 251 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fix #397
This pull request addresses a bug in how clipping paths are applied when rendering text with a positional offset, ensuring that clip paths are correctly transformed into the text's local coordinate space. It also adds comprehensive regression tests to validate the fix for various boolean clip operations and provides new reference images for test verification.
Bug Fixes:
clipPathsinDrawingCanvas<TPixel>.CreateTextCompositionCommandso that when text is rendered with a non-zeroRenderLocation, the clip paths are translated into the glyph-local coordinate space, ensuring correct clipping behavior. [1] [2] [3]Testing Improvements:
Issue_397to cover scenarios where text is drawn with intersecting and non-intersecting clipping paths using all boolean operations, validating both the fix and expected rendering output.Issue_397to support regression testing and visual verification. [1] [2] [3] [4] [5] [6] [7]