JPEG : Optimize ScaledCopyTo and Block8x8F for common scale factors#3115
Open
JimBobSquarePants wants to merge 4 commits intomainfrom
Open
JPEG : Optimize ScaledCopyTo and Block8x8F for common scale factors#3115JimBobSquarePants wants to merge 4 commits intomainfrom
JimBobSquarePants wants to merge 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Improves the performance of the JPEG block scaling and normalization logic in
Block8x8F. The main changes are the addition of specialized, loopless scaling routines for common scale factors and the refactoring of the SIMD normalization methods to clarify their responsibilities and remove unnecessary rounding. Fixes #1782The rounding removal affected our test comparisons far less than I expected but yielded clear visible improvements in some images. For example the replaced image here had blocking that was visible to my eye.
Benchmarks
Performance is sitting pretty following the changes. The playground benchmark has us sitting firmly in 2nd and 3rd place.