Delete guest user when SetYearDaySchedule is failed#2876
Delete guest user when SetYearDaySchedule is failed#2876HunsupJung wants to merge 1 commit intomainfrom
Conversation
|
Invitation URL: |
Test Results 72 files 494 suites 0s ⏱️ Results for commit 9b916c7. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9b916c7 |
Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>
HunsupJung
force-pushed
the
fix/delete-guest-user
branch
from
c3e1b38 to
9b916c7
Compare
HunsupJung
requested review from
ctowns,
hcarter-775,
nickolas-deboom and
tpmanley
| else | ||
| device.log.warn(string.format("Failed to clear user: %s", status)) | ||
| end |
There was a problem hiding this comment.
In the case this fails, what is the expected result?
Given the current logic, a failure would mean that
- lockCredentials commandResult is never emitted (HIGH importance)
- lockUsers commandResult for defaultSchedules will be emitted below, which will fail (MEDIUM importance)
Should we retry the ClearUser command again? If so, how many times?
Also, if it fails after some number of retries, I think we should emit a success result for lockCredentials. What do you think?
ctowns
left a comment
ctowns
left a comment
There was a problem hiding this comment.
@HunsupJung could you also fill out the Summary of Completed Tests section on the top PR comment?
| delete_aliro_from_table_as_user(device, userIdx) | ||
| delete_week_schedule_from_table_as_user(device, userIdx) | ||
| delete_year_schedule_from_table_as_user(device, userIdx) | ||
| if cmdName == "defaultSchedule" then |
There was a problem hiding this comment.
I think this handling that is specific to the defaultSchedule command could benefit from a short comment that explains why this is needed to improve readability.
3 participants
Type of Change
Checklist
Description of Change
Summary of Completed Tests