Ledvance zigbee EM EU plug

[LQ107]

Check all that apply

Type of Change

• WWST Certification Request
  • If this is your first time contributing code:
    • I have reviewed the README.md file
    • I have reviewed the CODE_OF_CONDUCT.md file
    • I have signed the CLA
  • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
• Bug fix
• New feature
• Refactor

Checklist

• I have performed a self-review of my code
• I have commented my code in hard-to-understand areas
• I have verified my changes by testing with a device or have communicated a plan for testing
• I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

[LQ107]

I had submit the Smartthings certification ,please help review the drive ,thank you very much .

[aleclorimer]

min_api_version fixes and resolving merge conflicts, but LGTM

[LQ107]

I have add the min_api_version opt value for each test , please help review again ,thank you very much .

[cjswedes]

Does the device report SimpleMetering.Divisor or the SimpleMetering.Multiplier attributes? The defaults will query these and set them if the device reports them.

If that is the case, this could be a fingerprint only change.

[LQ107]

yes , the device report SimpleMetering.Divisor or the SimpleMetering.Multiplier attributes

[cjswedes]

Since this is being reported by the device, the subdriver is not necessary. Please make this a fingerprint only change or explain why overriding the reported value on device init is necessary for the integration.

[LQ107]

Since the values of SimpleMetering.Divisor or SimpleMetering.Multiplier used by the device are different from those of the Smarthings standard driver, a custom sub driver needs to be used

[cjswedes]

I see now our defaults arent actually issuing a read or configuring those attributes. So I see why the subdriver is needed, and there is some precedence of just setting these values based on device model.

There is some precedence of setting these values (i.e. aurora-relay subdriver), but that should not be needed. The doConfigure handler for the zigbee switch driver issues reads for these values and the default handlers set the fields:

SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-switch/src/lifecycle_handlers/do_configure.lua

Lines 13 to 19 in 917bdad

	-- Additional one time configuration
	if device:supports_capability(capabilities.energyMeter) or device:supports_capability(capabilities.powerMeter) then
	local clusters = require "st.zigbee.zcl.clusters"
	-- Divisor and multipler for EnergyMeter
	device:send(clusters.SimpleMetering.attributes.Divisor:read(device))
	device:send(clusters.SimpleMetering.attributes.Multiplier:read(device))
	end

Only a fingerprint change is necessary

[LQ107]

Dear reviewers, I have added the min_api_version. Could you please help review again? Thank you very much.

[cjswedes]

The changes here are looking pretty good, but this subdriver should be a subdriver of the zigbee-switch-power subdriver. The aurora-relay subdriver exists for essentially the same reason; just to set the SIMPLE_METERING scaling fields.

Edit: I see that we do read the SimpleMetering.Divisor and SimpleMetering.Multiplier attributes in the zigbee switch default configure, so I dont think this subdriver is needed; those reads will trigger the default handlers when the device is joined which persist that value.

This should be a fingerprint only driver. Please test adding just the fingerprint.