Open
Conversation
- Switch from clang-tidy to clangd --check for ~10x faster lint - Add scripts/run_cpp_lint.py: parallel clangd checks with clean output - Add scripts/generate_compile_commands.py: standalone compile DB generation for IDE setup and as a dependency of fix_lint_cpp - Add scripts/_cpp_config.py: single source of truth for compile flags - Fix clang++-15 hardcode; use clang++ resolved via update-alternatives - Add fix_lint_cpp Makefile target for manual clang-tidy --fix runs - Move check_lint_cpp out of type_check and into lint_test where it belongs - Disable misc-confusable-identifiers (was 70% of lint time) and readability-function-cognitive-complexity in .clang-tidy
svij-sc
requested review from
kmontemayor2-sc,
mkolodner-sc,
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO