Skip to content

perf(build): expand lib stub pattern to cover unused transitive externals #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
John-David Dalton (jdalton) wants to merge 1 commit into from
Closed

perf(build): expand lib stub pattern to cover unused transitive externals #599

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .config/esbuild.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,21 @@ function createNodeProtocolPlugin() {
* minimal lookup covering just those types.
*/
function createLibStubPlugin() {
// Heavy lib modules that are eagerly required but never exercised
// by the SDK's actual code paths.
//
// Never-reached by SDK gateway modules:
// - globs.js / sorts.js → only used by fs helpers the SDK skips
// - external/npm-pack.js / pico-pack.js → Arborist/pacote/fast-glob,
// SDK only needs validateFiles() from fs
//
// Never-reached transitive external shims:
// - external/cacache.js → destructures from npm-pack (already stubbed),
// SDK's cache-with-ttl path degrades gracefully
// - external/del.js → pulled in by fs's lazy getDel() for safeDelete,
// SDK never calls safeDelete/safeDeleteSync
const libStubPattern =
/@socketsecurity\/lib\/dist\/(globs|sorts|external\/(npm-pack|pico-pack))\.js$/
/@socketsecurity\/lib\/dist\/(globs|sorts|external\/(npm-pack|pico-pack|cacache|del))\.js$/

const mimeDbPattern = /mime-db\/db\.json$/

Expand Down