Conversation
- autocompleteBar.ts now imports directly from ../../buttons and ../../dragAndDrop - autocompleteField.ts imports from ../../error and ../basic - autocompletePicker.ts imports from ../../error - forms.js no longer imports ../widgets at all
…e source .ts file to the mapped module name 'solid-ui-core/utils/keyHelpers/otherHelpers', which moduleNameMapper resolves to the compiled lib/ file that accessData.js actually imports from.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…aths - Add paths mappings to tsconfig.json so tsc resolves solid-ui-core/* and ui-forms/* sub-path imports - Change import * as ns to import ns (default import) for export= module - Bump solid-ui-core to 0.1.1 (fixes ns.d.ts being copied to lib/) - Use || true in build-types to suppress pre-existing style type errors (style.js uses module.exports interop that tsc can't model without converting to TypeScript — tracked as future work) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The forms area part of solid-ui but should really be a separate product. This refactor (done with the help of claude code) moves all the code around but changed nothing in the API of solid-ui. The tests all run still as solid-ui tests, and all pass.