Skip to content

fix(toolbar): anchor the connection and refresh actions at the leading edge#1544

Closed
datlechin wants to merge 1 commit into
mainfrom
fix/toolbar-leading-group
Closed

fix(toolbar): anchor the connection and refresh actions at the leading edge#1544
datlechin wants to merge 1 commit into
mainfrom
fix/toolbar-leading-group

Conversation

@datlechin
Copy link
Copy Markdown
Member

Follow-up to #1543 / #1479.

Problem

After centering the connection chip with centeredItemIdentifiers, the connection and refresh/save buttons clustered in the middle next to the chip instead of sitting at the leading edge, leaving the area after the window title empty.

Cause

connectionGroup and refreshSaveGroup were contiguous with principal (no space between them and the centered item). When centeredItemIdentifiers centers principal, items directly adjacent to it with no flexibleSpace separator are drawn attached to the centered chip, so they rode into the center.

Fix

Restore a flexibleSpace between refreshSaveGroup and principal, so there is a flexible space on both sides of the chip:

sidebarToggle, .sidebarTrackingSeparator, connectionGroup, refreshSaveGroup,
.flexibleSpace, principal, .flexibleSpace,
quickSwitcher, newTab, previewSQL, inspector

The two flexible spaces separate the three zones; centeredItemIdentifiers = [principal] still does the actual centering, so it stays robust against the visible window title. Result: connection/refresh/save anchored left, chip centered, view actions right.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2efe010a44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

.sidebarTrackingSeparator,
Self.connectionGroup,
Self.refreshSaveGroup,
.flexibleSpace,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Migrate saved toolbar layouts too

When a user already has an autosaved toolbar configuration from the prior build, this default-only spacer insertion will not repair that restored item list because autosavesConfiguration is enabled in init. In that scenario the saved ordering still lacks the spacer before principal, so the connection/refresh actions remain attached to the centered chip; consider migrating/resetting only the buggy saved ordering or versioning the toolbar identifier so affected profiles receive the new spacer.

Useful? React with 👍 / 👎.

@datlechin datlechin closed this Jun 1, 2026
@datlechin datlechin deleted the fix/toolbar-leading-group branch June 2, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant