Skip to content

feat(toolbar): make connection selectors navigational and move refresh/save to the trailing side#1549

Merged
datlechin merged 1 commit into
mainfrom
feat/toolbar-navigation-layout
Jun 1, 2026
Merged

feat(toolbar): make connection selectors navigational and move refresh/save to the trailing side#1549
datlechin merged 1 commit into
mainfrom
feat/toolbar-navigation-layout

Conversation

@datlechin
Copy link
Copy Markdown
Member

What

Reworks the main window toolbar layout:

  • The connection and database selectors (connectionGroup) are now an isNavigational group, so AppKit pins them to the leading side and keeps them out of normal overflow.
  • The Refresh/Save group moves from before the centered title to after the flexible space, sitting on the trailing side next to the tab and query controls.
  • Bumps toolbarIdentifier to com.TablePro.main.toolbar.v2. Reordering default items has no effect for existing users unless the identifier changes, because AppKit autosave restores the previously persisted layout. The bump forces a one-time reset to the new default arrangement.

Why

Groups navigation-style controls where macOS expects them and moves the action buttons next to the other action controls.

Notes

  • Localizable.xcstrings picks up strings extracted from recent work (JSON import, toolbar, password sources).
  • MainWindowToolbarValidationTests.toolbarIdentifierIsStable already expected .v2; the source bump makes it pass. Full MainWindowToolbarValidationTests suite passes.

Test plan

  • MainWindowToolbarValidationTests passes
  • swiftlint lint --strict clean on changed files
  • Manual: existing install shows the new default toolbar order on first launch after update

@datlechin datlechin merged commit b47f954 into main Jun 1, 2026
3 checks passed
@datlechin datlechin deleted the feat/toolbar-navigation-layout branch June 1, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant