Skip to content

feat: imperative infinite queries#8648

Draft
TkDodo wants to merge 26 commits into
mainfrom
feature/imperative-infinite-queries
Draft

feat: imperative infinite queries#8648
TkDodo wants to merge 26 commits into
mainfrom
feature/imperative-infinite-queries

Conversation

@TkDodo
Copy link
Copy Markdown
Collaborator

@TkDodo TkDodo commented Feb 14, 2025

let's bring back imperative infinite queries, but only allow them in an all-or-nothing mode, dependent on if getNextPageParam has been passed

let's bring back imperative infinite queries, but only allow them in an all-or-nothing mode, dependent on if `getNextPageParam` has been passed
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Feb 14, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 44b6f78

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 7s View ↗
nx run-many --target=build --exclude=examples/*... ❌ Failed 2m 4s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-03 20:51:05 UTC

@riwu
Copy link
Copy Markdown

riwu commented Feb 26, 2025

Thanks for this! Can we get it merged? It's critical to our use case of using it with AgGrid's serverside row model.

@guy-blast
Copy link
Copy Markdown

Hey @TkDodo as @riwu said for us it is also important any update when it will be merged?

@sina-ss
Copy link
Copy Markdown
Contributor

sina-ss commented Apr 18, 2025

any update for this?

@sgtsquiggs
Copy link
Copy Markdown

This has failing tests - someone would need to fix those and mark this as ready to review.

@TkDodo
Copy link
Copy Markdown
Collaborator Author

TkDodo commented Apr 30, 2025

it’s a POC PR with intentionally failing tests, as the types have not been implemented at all.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 3, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 565f5e89-9f19-4c88-ad43-9f0e078924ee

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/imperative-infinite-queries

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants