update deps & migrate to oxlint/oxfmt#805
Merged
tannerlinsley merged 6 commits intoTanStack:mainfrom Apr 1, 2026
Merged
Conversation
✅ Deploy Preview for tanstack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughReplaces ESLint/Prettier with Oxlint/Oxfmt, upgrades TypeScript and many dependencies, removes the Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
content-collections.ts (1)
8-14:⚠️ Potential issue | 🟡 MinorUse
z.iso.date()instead ofz.string().date()for Zod v4 consistency.In Zod v4,
z.iso.date()is the recommended primary method for ISO date string validation. Whilez.string().date()remains functional, the official Zod v4 documentation emphasizesz.iso.date()as the standard approach. Update line 10 to usez.iso.date()for consistency with Zod v4 conventions.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@content-collections.ts` around lines 8 - 14, Update the Zod schema for the "published" field to use the Zod v4 ISO date validator: replace the current z.string().date() usage inside the schema object (the published property) with z.iso.date() so the schema variable's published field validates ISO date strings using the recommended Zod v4 API.src/builder/api/remote.ts (1)
57-63:⚠️ Potential issue | 🟡 MinorRemove unsafe double cast or explicitly provide required
frameworkandtypescriptfields.The
StarterCompiledinterface requiresframework: stringandtypescript: booleanas non-optional fields (lines 52 and 54 ofsrc/builder/api/compile.ts). In the current implementation at lines 57-63, these fields are neither explicitly set nor guaranteed to exist in the spreadstarterobject from the externalloadStarterfunction. Theas unknown as StarterCompiledcast bypasses type checking and masks this issue. Either explicitly provide these fields when constructing the template object, or ensure the externalStartertype is properly validated to contain them.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/builder/api/remote.ts` around lines 57 - 63, The template object is being unsafely double-cast to StarterCompiled while missing required non-optional fields `framework` and `typescript`; update the construction in the code that builds `template` (the `template` constant created from `starter` returned by `loadStarter`) to explicitly provide `framework` (string) and `typescript` (boolean) or validate and assign them from `starter` before casting (e.g., derive/validate `starter.framework` and `starter.typescript` and set defaults or throw), ensuring the resulting object truly satisfies the `StarterCompiled` shape rather than relying on `as unknown as StarterCompiled`.src/components/builder/ExplorerPanel.tsx (1)
674-705:⚠️ Potential issue | 🟡 MinorThe split-button row now has non-clickable dead space.
The wrapper still provides the full-row hover/selected styling, but only the inner button is actionable. That leaves padding around the label area that looks clickable and no longer selects the addon. Please move the padding/hit area onto the button, or make the selection button fill the non-remove area, so the visual affordance matches the pointer target.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/builder/ExplorerPanel.tsx` around lines 674 - 705, The row wrapper currently holds the padding/hover/selected styling while only the inner button (onClick={() => setSelectedAddon(featureId)}) is actionable, creating dead space; move the layout/padding/rounded/conditional twMerge classes and the conditional style from the outer div onto the button (so the button becomes the full-row hit area) or alternatively make the button span the full non-remove area by giving it className="flex flex-1 min-w-0 items-center gap-2 text-left px-3 py-2 rounded-lg transition-colors" and applying the same isSelected conditional classes and style ({ backgroundColor: `${featureColor}20` }) to the button; keep the outer div as a simple key wrapper without hover/selection styles and preserve addedLines rendering and aria-pressed on the button.
🧹 Nitpick comments (1)
.oxlintrc.json (1)
135-142: Permissiveno-unused-varsignore patterns.The patterns
^e$and^error$allow any variable namedeorerrorto be unused without warning. This is quite broad and may mask legitimate unused variable issues beyond catch blocks.Consider narrowing to only catch error parameters by using
caughtErrorsIgnorePatternalone, or documenting why these patterns are needed.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.oxlintrc.json around lines 135 - 142, The current "no-unused-vars" rule is too permissive because argsIgnorePattern and varsIgnorePattern include (^e$) and (^error$), allowing any variables named e or error to be unused; remove (^e$) and (^error$) from argsIgnorePattern and varsIgnorePattern and leave only the underscore patterns there, then move the e/error patterns exclusively into caughtErrorsIgnorePattern (or document why broader ignores are required) so that only catch-block error parameters are exempt while other unused e/error variables still trigger warnings; update the rule keys "no-unused-vars", "argsIgnorePattern", "varsIgnorePattern", and "caughtErrorsIgnorePattern" accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content-collections.ts`:
- Line 10: The schema field named "published" currently uses the deprecated Zod
pattern z.string().date(); update it to use z.iso.date() so it validates ISO
YYYY-MM-DD strings under Zod v4 compatibility—locate the "published" field in
the content collection schema (the property named published) and replace
z.string().date() with z.iso.date(), keeping the rest of the schema intact.
In `@package.json`:
- Around line 78-79: The package.json currently lists the linting packages
"oxlint" and "oxlint-tsgolint" under dependencies; move both entries into the
devDependencies object (preserve their versions "^1.58.0" and "^0.19.0") and
remove them from dependencies, then update the lockfile by running the package
manager install (npm install or yarn) so the lockfile reflects the change;
confirm no runtime code imports these packages so moving them doesn't break
production builds.
In `@src/builder/api/remote.ts`:
- Around line 29-34: The returned object `integration` is being force-cast to
`StarterCompiled` but `RemoteIntegrationResponse.integration` is actually typed
as `AddOnCompiled`; fix this by either (A) keeping the add-on shape: change
`RemoteIntegrationResponse.integration` to `AddOnCompiled` and remove the `as
unknown as StarterCompiled` cast so `integration` is returned with its natural
type, or (B) if `StarterCompiled` is intended, construct `integration` with the
required `framework`, `mode`, and `typescript` fields and remove the
double-cast, updating the response type to `StarterCompiled`; locate the
`integration` construction in `src/builder/api/remote.ts` and update the
type/fields accordingly (referencing `RemoteIntegrationResponse`,
`AddOnCompiled`, `StarterCompiled`, and the `integration` variable).
In `@src/components/Doc.tsx`:
- Around line 125-133: The anchor builds a markdown link using the optional
variable pagePath (the template `${pagePath}.md` and the link text), which
yields "undefined.md" when pagePath is not provided; fix by guarding this anchor
in the Doc component so it only renders when pagePath is a non-empty string (or
compute a safePath = pagePath ?? '' and check safePath.length > 0 before
rendering), and update the href/text generation to use that safe value (replace
usages of `${pagePath}.md` and the inline {pagePath}.md text with the
guarded/safe value or omit the anchor entirely when missing).
In `@src/components/TrustedByMarquee.tsx`:
- Line 75: The CSS rule uses an unescaped selector so it won't match the
Tailwind arbitrary class animate-[marquee_linear_infinite]; update the selector
to the escaped form (escape the square brackets and any special chars) so
.animate-\[marquee_linear_infinite\] targets elements with
class="animate-[marquee_linear_infinite]"; locate the rule near TrustedByMarquee
(the .animate-[marquee_linear_infinite] declaration) and replace the selector
with the escaped version while keeping the animation properties unchanged.
In `@src/ui/Icons.tsx`:
- Line 12: The SVG group element in Icons.tsx uses the non-React prop name
clip-path (seen as <g clip-path="url(`#clip0_730_27136`)">) which breaks TSX
typing and attribute rendering; change the prop to the React/JSX camelCase name
clipPath on that <g> element (and any other SVG elements using dash-cased props)
so TypeScript and React will handle the attribute correctly while preserving the
same value ("url(`#clip0_730_27136`)").
In `@src/utils/cache.server.ts`:
- Around line 3-11: Remove the unnecessary "@ts-expect-error" inside the declare
global block for the docCache global declaration: update the global augmentation
so it simply declares var docCache: LRUCache<string, unknown> (no suppression),
while keeping the existing "@ts-expect-error" on the assignment expression that
sets globalThis.docCache = new LRUCache(...) in the docCache initialization
(retain that suppression if it prevents a real type error); this touches the
declare global block and the docCache initialization/assignment symbols.
In `@vite.config.ts`:
- Around line 14-18: The Vite alias configuration is missing the
content-collections mapping which causes imports in src/utils/blog.ts and
src/routes/blog.$.tsx to fail; update the resolve.alias block in vite.config.ts
(where '~' is configured) to add a 'content-collections' alias pointing to the
generated folder (./.content-collections/generated) so that imports using the
content-collections alias resolve correctly (ensure the alias pattern matches
how it's imported, e.g., 'content-collections' or 'content-collections/*'
mapping to path.resolve(__dirname, './.content-collections/generated')).
---
Outside diff comments:
In `@content-collections.ts`:
- Around line 8-14: Update the Zod schema for the "published" field to use the
Zod v4 ISO date validator: replace the current z.string().date() usage inside
the schema object (the published property) with z.iso.date() so the schema
variable's published field validates ISO date strings using the recommended Zod
v4 API.
In `@src/builder/api/remote.ts`:
- Around line 57-63: The template object is being unsafely double-cast to
StarterCompiled while missing required non-optional fields `framework` and
`typescript`; update the construction in the code that builds `template` (the
`template` constant created from `starter` returned by `loadStarter`) to
explicitly provide `framework` (string) and `typescript` (boolean) or validate
and assign them from `starter` before casting (e.g., derive/validate
`starter.framework` and `starter.typescript` and set defaults or throw),
ensuring the resulting object truly satisfies the `StarterCompiled` shape rather
than relying on `as unknown as StarterCompiled`.
In `@src/components/builder/ExplorerPanel.tsx`:
- Around line 674-705: The row wrapper currently holds the
padding/hover/selected styling while only the inner button (onClick={() =>
setSelectedAddon(featureId)}) is actionable, creating dead space; move the
layout/padding/rounded/conditional twMerge classes and the conditional style
from the outer div onto the button (so the button becomes the full-row hit area)
or alternatively make the button span the full non-remove area by giving it
className="flex flex-1 min-w-0 items-center gap-2 text-left px-3 py-2 rounded-lg
transition-colors" and applying the same isSelected conditional classes and
style ({ backgroundColor: `${featureColor}20` }) to the button; keep the outer
div as a simple key wrapper without hover/selection styles and preserve
addedLines rendering and aria-pressed on the button.
---
Nitpick comments:
In @.oxlintrc.json:
- Around line 135-142: The current "no-unused-vars" rule is too permissive
because argsIgnorePattern and varsIgnorePattern include (^e$) and (^error$),
allowing any variables named e or error to be unused; remove (^e$) and (^error$)
from argsIgnorePattern and varsIgnorePattern and leave only the underscore
patterns there, then move the e/error patterns exclusively into
caughtErrorsIgnorePattern (or document why broader ignores are required) so that
only catch-block error parameters are exempt while other unused e/error
variables still trigger warnings; update the rule keys "no-unused-vars",
"argsIgnorePattern", "varsIgnorePattern", and "caughtErrorsIgnorePattern"
accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ca9c4fc-67f3-43dc-8c79-aca18d869e79
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (31)
.oxfmtrc.json.oxlintrc.jsoncontent-collections.tseslint.config.mjsnetlify.tomlpackage.jsonscripts/mcp-eval/run-eval.tsscripts/test-npm-cache.tssrc/builder/api/remote.tssrc/components/AILibraryHero.tsxsrc/components/Doc.tsxsrc/components/DocsLayout.tsxsrc/components/ExampleDeployDialog.tsxsrc/components/StackBlitzEmbed.tsxsrc/components/TrustedByMarquee.tsxsrc/components/UserFeedbackSection.tsxsrc/components/builder/ConfigPanel.tsxsrc/components/builder/DeployDialog.tsxsrc/components/builder/ExplorerPanel.tsxsrc/components/builder/webcontainer/useWebContainerStore.tssrc/components/markdown/MarkdownTabsHandler.tsxsrc/components/markdown/PackageManagerTabs.tsxsrc/routeTree.gen.tssrc/routes/feed.tsxsrc/routes/partners.tsxsrc/ui/Icons.tsxsrc/ui/index.tssrc/utils/cache.server.tssrc/utils/documents.server.tstsconfig.jsonvite.config.ts
💤 Files with no reviewable changes (5)
- tsconfig.json
- eslint.config.mjs
- src/routes/feed.tsx
- src/routeTree.gen.ts
- scripts/mcp-eval/run-eval.ts
Comment on lines
+125
to
133
| <a | ||
| href={`${pagePath}.md`} | ||
| className="sr-only" | ||
| tabIndex={-1} | ||
| aria-hidden="true" | ||
| > | ||
| AI/LLM: This documentation page is available in plain markdown format at | ||
| {pagePath}.md | ||
| </a> |
There was a problem hiding this comment.
Guard optional pagePath before building markdown link.
pagePath is optional, but Line 126 always interpolates it. When absent, this renders undefined.md in both href and text.
💡 Suggested fix
- <a
- href={`${pagePath}.md`}
- className="sr-only"
- tabIndex={-1}
- aria-hidden="true"
- >
- AI/LLM: This documentation page is available in plain markdown format at
- {pagePath}.md
- </a>
+ {pagePath ? (
+ <a
+ href={`${pagePath}.md`}
+ className="sr-only"
+ tabIndex={-1}
+ aria-hidden="true"
+ >
+ AI/LLM: This documentation page is available in plain markdown format at
+ {pagePath}.md
+ </a>
+ ) : null}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <a | |
| href={`${pagePath}.md`} | |
| className="sr-only" | |
| tabIndex={-1} | |
| aria-hidden="true" | |
| > | |
| AI/LLM: This documentation page is available in plain markdown format at | |
| {pagePath}.md | |
| </a> | |
| {pagePath ? ( | |
| <a | |
| href={`${pagePath}.md`} | |
| className="sr-only" | |
| tabIndex={-1} | |
| aria-hidden="true" | |
| > | |
| AI/LLM: This documentation page is available in plain markdown format at | |
| {pagePath}.md | |
| </a> | |
| ) : null} |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/components/Doc.tsx` around lines 125 - 133, The anchor builds a markdown
link using the optional variable pagePath (the template `${pagePath}.md` and the
link text), which yields "undefined.md" when pagePath is not provided; fix by
guarding this anchor in the Doc component so it only renders when pagePath is a
non-empty string (or compute a safePath = pagePath ?? '' and check
safePath.length > 0 before rendering), and update the href/text generation to
use that safe value (replace usages of `${pagePath}.md` and the inline
{pagePath}.md text with the guarded/safe value or omit the anchor entirely when
missing).
| __html: ` | ||
| @keyframes marquee { 0% { transform: translateX(0); } 100% { transform: translateX(-33.333%); } } | ||
| .animate-\[marquee_linear_infinite\] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; } | ||
| .animate-[marquee_linear_infinite] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; } |
There was a problem hiding this comment.
Restore escaped class selector for the Tailwind arbitrary animation class.
Line 75 currently uses an unescaped selector, so this rule won’t match class="animate-[marquee_linear_infinite]" and the marquee animation can silently stop applying.
Proposed fix
- .animate-[marquee_linear_infinite] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; }
+ .animate-\[marquee_linear_infinite\] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .animate-[marquee_linear_infinite] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; } | |
| .animate-\[marquee_linear_infinite\] { animation-name: marquee; animation-timing-function: linear; animation-iteration-count: infinite; } |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/components/TrustedByMarquee.tsx` at line 75, The CSS rule uses an
unescaped selector so it won't match the Tailwind arbitrary class
animate-[marquee_linear_infinite]; update the selector to the escaped form
(escape the square brackets and any special chars) so
.animate-\[marquee_linear_infinite\] targets elements with
class="animate-[marquee_linear_infinite]"; locate the rule near TrustedByMarquee
(the .animate-[marquee_linear_infinite] declaration) and replace the selector
with the escaped version while keeping the animation properties unchanged.
Comment on lines
3
to
11
| declare global { | ||
| // @ts-expect-error - globalThis.docCache is set in the server entrypoint | ||
| var docCache: LRUCache<string, unknown> | ||
| } | ||
|
|
||
| const docCache = | ||
| globalThis.docCache || | ||
| // @ts-expect-error - globalThis.docCache is set in the server entrypoint | ||
| (globalThis.docCache = new LRUCache<string, unknown>({ |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Check if TypeScript reports unused `@ts-expect-error` directives
# Find tsconfig and run type check to see if there are unused directive warnings
fd -t f 'tsconfig.*\.json$' --max-depth 2 | head -1 | xargs -I{} echo "Found tsconfig: {}"
# Search for how this file is being type-checked
rg -l "cache\.server" --type ts -g '!node_modules'Repository: TanStack/tanstack.com
Length of output: 177
🏁 Script executed:
cat -n src/utils/cache.server.ts | head -20Repository: TanStack/tanstack.com
Length of output: 749
🏁 Script executed:
# Run TypeScript type checking to see if there are unused `@ts-expect-error` warnings
npm list typescript 2>/dev/null | head -5Repository: TanStack/tanstack.com
Length of output: 110
🏁 Script executed:
# Check if TypeScript can find any actual errors without the `@ts-expect-error` directives
# by looking at the tsconfig and trying to understand strict settings
cat tsconfig.json | jq -r '.compilerOptions | {strict, noImplicitAny, declaration}'Repository: TanStack/tanstack.com
Length of output: 133
🏁 Script executed:
# Run TypeScript compiler to check for errors and unused `@ts-expect-error` directives
npx tsc --noEmit 2>&1 | grep -A 3 "cache.server\|TS2578\|Unused" | head -20Repository: TanStack/tanstack.com
Length of output: 47
🏁 Script executed:
# Check the actual TypeScript version and strict settings more thoroughly
cat tsconfig.json | head -40Repository: TanStack/tanstack.com
Length of output: 834
🏁 Script executed:
# Create a temporary test version without `@ts-expect-error` on line 4
cat > /tmp/cache_test.ts << 'EOF'
import { LRUCache } from 'lru-cache'
declare global {
var docCache: LRUCache<string, unknown>
}
const docCache =
globalThis.docCache ||
(globalThis.docCache = new LRUCache<string, unknown>({
max: 300,
ttl: 1000,
}))
EOF
# Try to type-check this version
cd /home/jailuser/git && npx tsc --noEmit --lib DOM,DOM.Iterable,ES2022 --strict --esModuleInterop --module ESNext --moduleResolution Bundler /tmp/cache_test.ts 2>&1Repository: TanStack/tanstack.com
Length of output: 206
🏁 Script executed:
# Also check if globalThis is properly augmented in the current setup
# by looking at TypeScript's understanding of globalThis.docCache
rg -A 5 "declare global" src/utils/cache.server.tsRepository: TanStack/tanstack.com
Length of output: 219
🏁 Script executed:
# Backup the original file
cp src/utils/cache.server.ts src/utils/cache.server.ts.bak
# Create a version without the `@ts-expect-error` on line 4 (inside declare global)
cat > src/utils/cache.server.ts << 'EOF'
import { LRUCache } from 'lru-cache'
declare global {
var docCache: LRUCache<string, unknown>
}
const docCache =
globalThis.docCache ||
// `@ts-expect-error` - globalThis.docCache is set in the server entrypoint
(globalThis.docCache = new LRUCache<string, unknown>({
max: 300,
// ttl: 1,
ttl: process.env.NODE_ENV === 'production' ? 1 : 1000000,
}))
export async function fetchCached<T>(opts: {
fn: () => Promise<T>
key: string
ttl: number
}) {
return {}
}
EOF
# Run TypeScript type check
npx tsc --noEmit 2>&1 | grep -E "cache\.server|error TS"
# Restore original
mv src/utils/cache.server.ts.bak src/utils/cache.server.tsRepository: TanStack/tanstack.com
Length of output: 130
🏁 Script executed:
# Now test removing line 10's suppression while keeping line 4's
cp src/utils/cache.server.ts src/utils/cache.server.ts.bak
cat > src/utils/cache.server.ts << 'EOF'
import { LRUCache } from 'lru-cache'
declare global {
// `@ts-expect-error` - globalThis.docCache is set in the server entrypoint
var docCache: LRUCache<string, unknown>
}
const docCache =
globalThis.docCache ||
(globalThis.docCache = new LRUCache<string, unknown>({
max: 300,
// ttl: 1,
ttl: process.env.NODE_ENV === 'production' ? 1 : 1000000,
}))
export async function fetchCached<T>(opts: {
fn: () => Promise<T>
key: string
ttl: number
}) {
return {}
}
EOF
# Run TypeScript type check
npx tsc --noEmit 2>&1 | grep -E "cache\.server|error TS"
# Restore original
mv src/utils/cache.server.ts.bak src/utils/cache.server.tsRepository: TanStack/tanstack.com
Length of output: 222
🏁 Script executed:
# Test removing BOTH suppressions
cp src/utils/cache.server.ts src/utils/cache.server.ts.bak
cat > src/utils/cache.server.ts << 'EOF'
import { LRUCache } from 'lru-cache'
declare global {
var docCache: LRUCache<string, unknown>
}
const docCache =
globalThis.docCache ||
(globalThis.docCache = new LRUCache<string, unknown>({
max: 300,
// ttl: 1,
ttl: process.env.NODE_ENV === 'production' ? 1 : 1000000,
}))
export async function fetchCached<T>(opts: {
fn: () => Promise<T>
key: string
ttl: number
}) {
return {}
}
EOF
# Run TypeScript type check
npx tsc --noEmit 2>&1 | grep -E "cache\.server|error TS"
# Restore original
mv src/utils/cache.server.ts.bak src/utils/cache.server.tsRepository: TanStack/tanstack.com
Length of output: 222
🏁 Script executed:
# Check for ESLint configuration that might validate `@ts-expect-error`
fd -t f '.eslintrc*' -o 'eslint.config.*'Repository: TanStack/tanstack.com
Length of output: 214
🏁 Script executed:
# Look for other `@ts-expect-error` usages to understand the pattern
rg "@ts-expect-error" --type ts --max-count 20Repository: TanStack/tanstack.com
Length of output: 747
🏁 Script executed:
# Search for other globalThis declarations to understand the pattern
rg "declare global" --type ts -A 3Repository: TanStack/tanstack.com
Length of output: 780
🏁 Script executed:
# Verify the context of why line 4 might need suppression by checking TypeScript docs
# Look for how globalThis is augmented and if there's any actual error case
rg -B 2 -A 5 "globalThis\." src/utils/cache.server.tsRepository: TanStack/tanstack.com
Length of output: 400
🏁 Script executed:
# Check if ESLint or other tooling catches unused `@ts-expect-error`
fd -name '.eslintrc*' -o -name 'eslint.config.*' 2>/dev/nullRepository: TanStack/tanstack.com
Length of output: 47
Remove the unnecessary @ts-expect-error on line 4.
The suppression inside the declare global block is non-standard. Other global declarations in the codebase (src/types/css-anchor-positioning.d.ts, src/routes/__root.tsx) do not use @ts-expect-error inside declare global blocks—this is standard TypeScript syntax that does not produce errors. In strict mode, unused @ts-expect-error directives trigger TS2578 errors.
The suppression on line 10 (the assignment) may be necessary and should be retained pending confirmation that it suppresses an actual type error.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/utils/cache.server.ts` around lines 3 - 11, Remove the unnecessary
"@ts-expect-error" inside the declare global block for the docCache global
declaration: update the global augmentation so it simply declares var docCache:
LRUCache<string, unknown> (no suppression), while keeping the existing
"@ts-expect-error" on the assignment expression that sets globalThis.docCache =
new LRUCache(...) in the docCache initialization (retain that suppression if it
prevents a real type error); this touches the declare global block and the
docCache initialization/assignment symbols.
Comment on lines
+14
to
+18
| resolve: { | ||
| alias: { | ||
| '~': path.resolve(__dirname, './src'), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check if 'content-collections' alias is used in imports
rg -n "from ['\"]content-collections['\"]" --type=ts --type=tsx
rg -n "import.*content-collections" --type=ts --type=tsx
# Also check for any direct imports
ast-grep --pattern 'import $_ from "content-collections"'Repository: TanStack/tanstack.com
Length of output: 120
🏁 Script executed:
# Fix the search - rg doesn't support tsx file type, use ts or search all files
rg "content-collections" --type ts -n
rg "content-collections" -nRepository: TanStack/tanstack.com
Length of output: 2283
🏁 Script executed:
# Also verify the tsconfig.json definition mentioned in the review
find . -name "tsconfig.json" -type f | head -5Repository: TanStack/tanstack.com
Length of output: 80
🏁 Script executed:
# Check if there's a .content-collections directory
find . -name "*content-collections*" -type dRepository: TanStack/tanstack.com
Length of output: 47
Missing content-collections path alias will cause resolution failures.
The tsconfig.json defines two path aliases: ~/* → ./src/* and content-collections → ./.content-collections/generated. Only the ~ alias is configured in vite.config.ts. Since vite-tsconfig-paths was removed, imports using the content-collections alias in src/utils/blog.ts and src/routes/blog.$.tsx will fail to resolve at build time.
Proposed fix
resolve: {
alias: {
'~': path.resolve(__dirname, './src'),
+ 'content-collections': path.resolve(__dirname, './.content-collections/generated'),
},
},📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| resolve: { | |
| alias: { | |
| '~': path.resolve(__dirname, './src'), | |
| }, | |
| }, | |
| resolve: { | |
| alias: { | |
| '~': path.resolve(__dirname, './src'), | |
| 'content-collections': path.resolve(__dirname, './.content-collections/generated'), | |
| }, | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@vite.config.ts` around lines 14 - 18, The Vite alias configuration is missing
the content-collections mapping which causes imports in src/utils/blog.ts and
src/routes/blog.$.tsx to fail; update the resolve.alias block in vite.config.ts
(where '~' is configured) to add a 'content-collections' alias pointing to the
generated folder (./.content-collections/generated) so that imports using the
content-collections alias resolve correctly (ensure the alias pattern matches
how it's imported, e.g., 'content-collections' or 'content-collections/*'
mapping to path.resolve(__dirname, './.content-collections/generated')).
…k.yaml; rm prettier files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Refactor