Skip to content

fix(builder): prevent button height shift in database/ORM selection#812

Open
kasimthecoder wants to merge 1 commit intoTanStack:mainfrom
kasimthecoder:fix-issue-689
Open

fix(builder): prevent button height shift in database/ORM selection#812
kasimthecoder wants to merge 1 commit intoTanStack:mainfrom
kasimthecoder:fix-issue-689

Conversation

@kasimthecoder
Copy link
Copy Markdown

@kasimthecoder kasimthecoder commented Apr 7, 2026

Fixes #689

Summary:
Resolved an issue where button height changed when selecting database/ORM options in the builder.

Cause:
Inconsistent height handling in the layout caused buttons to resize on selection.

Fix:
Adjusted styling to ensure consistent height and alignment across all options.

Testing:

  • Verified UI consistency across all database/ORM options
  • No layout shift observed on selection

Summary by CodeRabbit

Release Notes

  • Style
    • Enhanced visual layout of feature picker buttons to ensure they properly fill their grid cell containers for improved consistency and alignment.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

👷 Deploy request for tanstack pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit d0afbf4

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5e94bcc3-2525-4e32-b900-c37c0b15a915

📥 Commits

Reviewing files that changed from the base of the PR and between 43fa62c and d0afbf4.

📒 Files selected for processing (1)
  • src/components/builder/FeaturePicker.tsx

📝 Walkthrough

Walkthrough

Updated the FeatureCard button styling in FeaturePicker.tsx by adding h-full class to the className, allowing buttons to stretch to full height of their parent grid cell instead of maintaining default height.

Changes

Cohort / File(s) Summary
Button Height Fix
src/components/builder/FeaturePicker.tsx
Added h-full class to FeatureCard button styling to ensure buttons stretch vertically to fill parent grid cell height.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰✨
A button once sat in a cell,
Not quite tall—a height-matching spell!
With h-full added with care,
Now it stretches up through the air!
Small fix, big joy—all is well! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing a button height shift issue in the database/ORM selection interface by adding h-full styling.
Linked Issues check ✅ Passed The code change directly addresses issue #689 by adding h-full class to FeatureCard styling to prevent button height shifts during database/ORM selection.
Out of Scope Changes check ✅ Passed The change is narrowly scoped to the single file and styling property requested in issue #689, with no unrelated modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button Height Changes on TanStack Builder

1 participant